Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update XRootD to 5.x in CMSSW 10_6_X #8484

Merged
merged 9 commits into from May 12, 2023

Conversation

iarspider
Copy link
Contributor

please test for CMSSW 10_6_X

@iarspider
Copy link
Contributor Author

please test for CMSSW 10_6_X

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2023

A new Pull Request was created by @iarspider for branch IB/CMSSW_10_6_X/gcc700.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

please test

@smuzaffar
Copy link
Contributor

please test for CMSSW 10_6_X

@iarspider , release queueis wrong here it should be CMSSW_10_6_X :-) or please test should be enough as bot is going to use the PR base branch to find the correct cmssw queue

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2023

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b26359/32302/summary.html
COMMIT: 646aab7
CMSSW: CMSSW_10_6_X_2023-04-30-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8484/32302/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

XrdOucErrInfo &einfo) {return true;}
^~~~~
[6601/8903] : && /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc700/external/gcc/7.0.0-pafccj/bin/g++  -D__ROOFIT_NOBANNER -Wno-implicit-fallthrough -Wno-noexcept-type -pipe -m64  -Wshadow -Wall -W -Woverloaded-virtual -fsigned-char -pthread -std=c++1z -O3 -DNDEBUG  -rdynamic core/clib/CMakeFiles/Clib.dir/src/Demangle.c.o core/clib/CMakeFiles/Clib.dir/src/attach.c.o core/clib/CMakeFiles/Clib.dir/src/detach.c.o core/clib/CMakeFiles/Clib.dir/src/getpagesize.c.o core/clib/CMakeFiles/Clib.dir/src/keys.c.o core/clib/CMakeFiles/Clib.dir/src/mcalloc.c.o core/clib/CMakeFiles/Clib.dir/src/mfree.c.o core/clib/CMakeFiles/Clib.dir/src/mmalloc.c.o core/clib/CMakeFiles/Clib.dir/src/mmapsup.c.o core/clib/CMakeFiles/Clib.dir/src/mmcheck.c.o core/clib/CMakeFiles/Clib.dir/src/mmemalign.c.o core/clib/CMakeFiles/Clib.dir/src/mmstats.c.o core/clib/CMakeFiles/Clib.dir/src/mmtrace.c.o core/clib/CMakeFiles/Clib.dir/src/mrealloc.c.o core/clib/CMakeFiles/Clib.dir/src/mvalloc.c.o core/clib/CMakeFiles/Clib.dir/src/sbrksup.c.o core/clib/CMakeFiles/Clib.dir/src/snprintf.c.o core/clib/CMakeFiles/Clib.dir/src/strlcat.c.o core/clib/CMakeFiles/Clib.dir/src/strlcpy.c.o core/clingutils/CMakeFiles/ClingUtils.dir/src/RStl.cxx.o core/clingutils/CMakeFiles/ClingUtils.dir/src/TClingUtils.cxx.o core/dictgen/CMakeFiles/Dictgen.dir/src/BaseSelectionRule.cxx.o core/dictgen/CMakeFiles/Dictgen.dir/src/ClassSelectionRule.cxx.o core/dictgen/CMakeFiles/Dictgen.dir/src/DictSelectionReader.cxx.o core/dictgen/CMakeFiles/Dictgen.dir/src/LinkdefReader.cxx.o core/dictgen/CMakeFiles/Dictgen.dir/src/Scanner.cxx.o core/dictgen/CMakeFiles/Dictgen.dir/src/SelectionRules.cxx.o core/dictgen/CMakeFiles/Dictgen.dir/src/TModuleGenerator.cxx.o core/dictgen/CMakeFiles/Dictgen.dir/src/VariableSelectionRule.cxx.o core/dictgen/CMakeFiles/Dictgen.dir/src/XMLReader.cxx.o core/dictgen/CMakeFiles/Dictgen.dir/src/rootcling_impl.cxx.o core/foundation/CMakeFiles/Foundation_Stage1.dir/src/RConversionRuleParser.cxx.o core/foundation/CMakeFiles/Foundation_Stage1.dir/src/TClassEdit.cxx.o core/rootcling_stage1/CMakeFiles/rootcling_stage1.dir/src/rootcling_stage1.cxx.o  -o core/rootcling_stage1/src/rootcling_stage1  -Wl,-rpath,/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc700/external/zlib-x86_64/1.2.11-pafccj/lib  interpreter/llvm/src/lib/libclingInterpreter.a  interpreter/llvm/src/lib/libclingMetaProcessor.a  interpreter/llvm/src/lib/libclingUtils.a  -ldl  -lpthread  interpreter/llvm/src/lib/libclingInterpreter.a  interpreter/llvm/src/lib/libclangCodeGen.a  interpreter/llvm/src/lib/libclangRewriteFrontend.a  interpreter/llvm/src/lib/libclangFrontend.a  interpreter/llvm/src/lib/libclangDriver.a  interpreter/llvm/src/lib/libclangRewrite.a  interpreter/llvm/src/lib/libclangSerialization.a  interpreter/llvm/src/lib/libLLVMCoroutines.a  interpreter/llvm/src/lib/libLLVMCoverage.a  interpreter/llvm/src/lib/libLLVMLTO.a  interpreter/llvm/src/lib/libLLVMObjCARCOpts.a  interpreter/llvm/src/lib/libLLVMPasses.a  interpreter/llvm/src/lib/libLLVMipo.a  interpreter/llvm/src/lib/libLLVMIRReader.a  interpreter/llvm/src/lib/libLLVMAsmParser.a  interpreter/llvm/src/lib/libLLVMLinker.a  interpreter/llvm/src/lib/libLLVMInstrumentation.a  interpreter/llvm/src/lib/libLLVMVectorize.a  interpreter/llvm/src/lib/libLLVMOption.a  interpreter/llvm/src/lib/libLLVMOrcJIT.a  interpreter/llvm/src/lib/libLLVMExecutionEngine.a  interpreter/llvm/src/lib/libLLVMRuntimeDyld.a  interpreter/llvm/src/lib/libLLVMX86CodeGen.a  interpreter/llvm/src/lib/libLLVMAsmPrinter.a  interpreter/llvm/src/lib/libLLVMDebugInfoCodeView.a  interpreter/llvm/src/lib/libLLVMDebugInfoMSF.a  interpreter/llvm/src/lib/libLLVMGlobalISel.a  interpreter/llvm/src/lib/libLLVMSelectionDAG.a  interpreter/llvm/src/lib/libLLVMCodeGen.a  interpreter/llvm/src/lib/libLLVMScalarOpts.a  interpreter/llvm/src/lib/libLLVMInstCombine.a  interpreter/llvm/src/lib/libLLVMTarget.a  interpreter/llvm/src/lib/libLLVMTransformUtils.a  interpreter/llvm/src/lib/libLLVMBitWriter.a  interpreter/llvm/src/lib/libLLVMAnalysis.a  interpreter/llvm/src/lib/libLLVMProfileData.a  interpreter/llvm/src/lib/libLLVMX86AsmParser.a  interpreter/llvm/src/lib/libLLVMX86Desc.a  interpreter/llvm/src/lib/libLLVMObject.a  interpreter/llvm/src/lib/libLLVMBitReader.a  interpreter/llvm/src/lib/libLLVMX86AsmPrinter.a  interpreter/llvm/src/lib/libLLVMX86Disassembler.a  interpreter/llvm/src/lib/libLLVMX86Info.a  interpreter/llvm/src/lib/libLLVMMCDisassembler.a  interpreter/llvm/src/lib/libLLVMX86Utils.a  interpreter/llvm/src/lib/libclingUtils.a  interpreter/llvm/src/lib/libclangParse.a  interpreter/llvm/src/lib/libLLVMMCParser.a  interpreter/llvm/src/lib/libclangSema.a  interpreter/llvm/src/lib/libclangAnalysis.a  interpreter/llvm/src/lib/libclangEdit.a  interpreter/llvm/src/lib/libclangAST.a  interpreter/llvm/src/lib/libclangLex.a  interpreter/llvm/src/lib/libclangBasic.a  interpreter/llvm/src/lib/libLLVMMC.a  interpreter/llvm/src/lib/libLLVMCore.a  interpreter/llvm/src/lib/libLLVMBinaryFormat.a  interpreter/llvm/src/lib/libLLVMSupport.a  -lrt  -ldl  -ltinfo  -lpthread  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc700/external/zlib-x86_64/1.2.11-pafccj/lib/libz.so  -lm  interpreter/llvm/src/lib/libLLVMDemangle.a && :
[6602/8903] /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc700/external/gcc/7.0.0-pafccj/bin/g++   -Iinclude -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc700/lcg/root/6.14.09-b078167ffd553a8d719e9b1d57bc95b5/root-6.14.09/core/metacling/src/../res -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc700/lcg/root/6.14.09-b078167ffd553a8d719e9b1d57bc95b5/root-6.14.09/core/metacling/src/../../clingutils/res -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc700/lcg/root/6.14.09-b078167ffd553a8d719e9b1d57bc95b5/root-6.14.09/core/metacling/src/../../foundation/res -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc700/lcg/root/6.14.09-b078167ffd553a8d719e9b1d57bc95b5/root-6.14.09/interpreter/cling/include -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc700/lcg/root/6.14.09-b078167ffd553a8d719e9b1d57bc95b5/root-6.14.09/interpreter/llvm/src/tools/clang/include -isystem interpreter/llvm/src/tools/clang/include -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc700/lcg/root/6.14.09-b078167ffd553a8d719e9b1d57bc95b5/root-6.14.09/interpreter/llvm/src/include -isystem interpreter/llvm/src/include -D__ROOFIT_NOBANNER -Wno-implicit-fallthrough -Wno-noexcept-type -pipe -m64  -Wshadow -Wall -W -Woverloaded-virtual -fsigned-char -pthread -std=c++1z -fvisibility=hidden -Wno-shadow -fno-strict-aliasing -Wno-unused-parameter -Wwrite-strings -Wno-long-long -Wno-missing-field-initializers  -DLLVM_BUILD_GLOBAL_ISEL -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Wno-maybe-uninitialized -O3 -DNDEBUG -fPIC -MD -MT core/metacling/src/CMakeFiles/MetaCling.dir/TCling.cxx.o -MF core/metacling/src/CMakeFiles/MetaCling.dir/TCling.cxx.o.d -o core/metacling/src/CMakeFiles/MetaCling.dir/TCling.cxx.o -c /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc700/lcg/root/6.14.09-b078167ffd553a8d719e9b1d57bc95b5/root-6.14.09/core/metacling/src/TCling.cxx
ninja: build stopped: subcommand failed.
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.Z6Zkiy (%build)


RPM build errors:
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.Z6Zkiy (%build)



@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2023

Pull request #8484 was updated.

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2023

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b26359/32315/summary.html
COMMIT: ffa7bb3
CMSSW: CMSSW_10_6_X_2023-04-30-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8484/32315/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

XrdOucErrInfo &einfo) {return true;}
^~~~~
[6594/8903] /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc700/external/gcc/7.0.0-pafccj/bin/gcc  -Iinclude -D__ROOFIT_NOBANNER -Wno-implicit-fallthrough -pipe -m64 -Wall -W -pthread -O3 -DNDEBUG -fPIC -MD -MT graf3d/glew/CMakeFiles/GLEW.dir/src/glew.c.o -MF graf3d/glew/CMakeFiles/GLEW.dir/src/glew.c.o.d -o graf3d/glew/CMakeFiles/GLEW.dir/src/glew.c.o   -c /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc700/lcg/root/6.14.09-30047398a13f855663cdee0b5e967bb2/root-6.14.09/graf3d/glew/src/glew.c
[6595/8903] /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc700/external/gcc/7.0.0-pafccj/bin/g++   -Iinclude -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc700/lcg/root/6.14.09-30047398a13f855663cdee0b5e967bb2/root-6.14.09/core/metacling/src/../res -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc700/lcg/root/6.14.09-30047398a13f855663cdee0b5e967bb2/root-6.14.09/core/metacling/src/../../clingutils/res -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc700/lcg/root/6.14.09-30047398a13f855663cdee0b5e967bb2/root-6.14.09/core/metacling/src/../../foundation/res -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc700/lcg/root/6.14.09-30047398a13f855663cdee0b5e967bb2/root-6.14.09/interpreter/cling/include -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc700/lcg/root/6.14.09-30047398a13f855663cdee0b5e967bb2/root-6.14.09/interpreter/llvm/src/tools/clang/include -isystem interpreter/llvm/src/tools/clang/include -isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc700/lcg/root/6.14.09-30047398a13f855663cdee0b5e967bb2/root-6.14.09/interpreter/llvm/src/include -isystem interpreter/llvm/src/include -D__ROOFIT_NOBANNER -Wno-implicit-fallthrough -Wno-noexcept-type -pipe -m64  -Wshadow -Wall -W -Woverloaded-virtual -fsigned-char -pthread -std=c++1z -fvisibility=hidden -Wno-shadow -fno-strict-aliasing -Wno-unused-parameter -Wwrite-strings -Wno-long-long -Wno-missing-field-initializers  -DLLVM_BUILD_GLOBAL_ISEL -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Wno-maybe-uninitialized -O3 -DNDEBUG -fPIC -MD -MT core/metacling/src/CMakeFiles/MetaCling.dir/TCling.cxx.o -MF core/metacling/src/CMakeFiles/MetaCling.dir/TCling.cxx.o.d -o core/metacling/src/CMakeFiles/MetaCling.dir/TCling.cxx.o -c /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc700/lcg/root/6.14.09-30047398a13f855663cdee0b5e967bb2/root-6.14.09/core/metacling/src/TCling.cxx
ninja: build stopped: subcommand failed.
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.OmstWN (%build)


RPM build errors:
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.OmstWN (%build)



@smuzaffar
Copy link
Contributor

smuzaffar commented May 3, 2023

test parameters:

@smuzaffar
Copy link
Contributor

@iarspider
Copy link
Contributor Author

test_occi_std_length (the only unit test that failed) also fails in IBs

@smuzaffar
Copy link
Contributor

yes this test is failing for every IB 9 looks like some issues with oracle connection at cern).

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b26359/32547/summary.html
COMMIT: 49b6bfa
CMSSW: CMSSW_10_6_X_2023-05-07-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8484/32547/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test_occi_std_length had ERRORS

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215686
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215351
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 143 log files, 102 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@rappoccio
Copy link

Should we also merge this one @smuzaffar ? Do you expect the checks to pass once the oracle connection is re-established?

@iarspider
Copy link
Contributor Author

@rappoccio the db failure is unrelated, it should be fixed by cms-sw/cmssw#41630

@cmsbuild
Copy link
Contributor

Pull request #8484 was updated.

@smuzaffar
Copy link
Contributor

please test

yes @rappoccio , we should merge this too along with cms-sw/cmssw#41599 . let me re-run the tests once more. Note the the oracle unit test will still fail in 10.6.X

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b26359/32570/summary.html
COMMIT: f968e87
CMSSW: CMSSW_10_6_X_2023-05-07-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8484/32570/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test_occi_std_length had ERRORS

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215686
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215351
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 143 log files, 102 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

smuzaffar commented May 12, 2023

+externals

@rappoccio @perrotta this is ready to go in 10.6.X ( along with cms-sw/cmssw#41599 ). I would suggest to merge these and let the IBs run for few days before cutting a 10.6.X release.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_6_X/gcc700 IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link

+1

@rappoccio
Copy link

merge

@cmsbuild cmsbuild merged commit 8247160 into IB/CMSSW_10_6_X/gcc700 May 12, 2023
10 of 11 checks passed
@iarspider iarspider deleted the xrootd-5x-to-10_6 branch May 15, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants