Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Root update master 20230926 #8723

Closed
wants to merge 1 commit into from
Closed

Root update master 20230926 #8723

wants to merge 1 commit into from

Conversation

iarspider
Copy link
Contributor

No description provided.

@iarspider iarspider changed the base branch from IB/CMSSW_13_3_X/master to IB/CMSSW_13_3_X/rootmaster September 26, 2023 11:47
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for branch IB/CMSSW_13_3_X/rootmaster.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da5d60/34905/summary.html
COMMIT: 3bb70bf
CMSSW: CMSSW_13_3_ROOT6_X_2023-09-25-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8723/34905/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_ROOT6_X_2023-09-25-2300/src/DQMOffline/Alignment/src/DiMuonMassBiasClient.cc:2:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/gcc/11.4.1-30ebdc301ebd200f2ae0e3d880258e65/include/c++/11.4.1/bits/unique_ptr.h: In instantiation of 'void std::default_delete<_Tp>::operator()(_Tp*) const [with _Tp = RooFitResult]':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/gcc/11.4.1-30ebdc301ebd200f2ae0e3d880258e65/include/c++/11.4.1/bits/unique_ptr.h:361:17:   required from 'std::unique_ptr<_Tp, _Dp>::~unique_ptr() [with _Tp = RooFitResult; _Dp = std::default_delete]'
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/lcg/root/6.29.01-e72c8e35c9d6a8bb9738f0a080da38d4/include/RooAbsPdf.h:158:47:   required from 'RooFitResult* RooAbsPdf::fitTo(RooAbsData&, const CmdArgs_t& ...) [with CmdArgs_t = {RooCmdArg}; RooFit::OwningPtr = RooFitResult*]'
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_ROOT6_X_2023-09-25-2300/src/DQMOffline/Alignment/src/DiMuonMassBiasClient.cc:372:20:   required from here
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/gcc/11.4.1-30ebdc301ebd200f2ae0e3d880258e65/include/c++/11.4.1/bits/unique_ptr.h:83:23: error: invalid application of 'sizeof' to incomplete type 'RooFitResult'
   83 |         static_assert(sizeof(_Tp)>0,
      |                       ^~~~~~~~~~~
gmake: *** [tmp/el8_amd64_gcc11/src/DQMOffline/Alignment/src/DQMOfflineAlignment/DiMuonMassBiasClient.cc.o] Error 1
>> Building edm plugin tmp/el8_amd64_gcc11/src/DQMOffline/Alignment/src/DQMOfflineAlignment/libDQMOfflineAlignment.so
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/gcc/11.4.1-30ebdc301ebd200f2ae0e3d880258e65/bin/../lib/gcc/x86_64-redhat-linux-gnu/11.4.1/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find tmp/el8_amd64_gcc11/src/DQMOffline/Alignment/src/DQMOfflineAlignment/DiMuonMassBiasClient.cc.o: No such file or directory

@iarspider
Copy link
Contributor Author

please test with cms-sw/cmssw#42899

@iarspider
Copy link
Contributor Author

@cmsbuild ping

@iarspider
Copy link
Contributor Author

please test with cms-sw/cmssw#42899

@smuzaffar
Copy link
Contributor

please test with cms-sw/cmssw#42899 for CMSSW_13_3_ROOT6_X

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da5d60/34954/summary.html
COMMIT: 3bb70bf
CMSSW: CMSSW_13_3_X_2023-09-28-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8723/34954/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da5d60/34954/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da5d60/34954/git-merge-result

Build

I found compilation error when building:

#10 0x0000000000406ede in _start ()
===========================================================


/bin/sh: line 1: 888769 Segmentation fault      (core dumped) edmWriteConfigs -p /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_X_2023-09-28-1100/tmp/el8_amd64_gcc11/src/Calibration/LumiAlCaRecoProducers/plugins/AlcaPCCEventProducer/libAlcaPCCEventProducer.so
gmake: *** [lib/el8_amd64_gcc11/AlcaPCCEventProducer.edmplugin] Error 1
Entering library rule at src/Calibration/LumiAlCaRecoProducers/plugins
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_X_2023-09-28-1100/src/Calibration/LumiAlCaRecoProducers/plugins/AlcaPCCIntegrator.cc
>> Building edm plugin tmp/el8_amd64_gcc11/src/Calibration/LumiAlCaRecoProducers/plugins/AlcaPCCIntegrator/libAlcaPCCIntegrator.so
Leaving library rule at src/Calibration/LumiAlCaRecoProducers/plugins
@@@@ Running edmWriteConfigs for AlcaPCCIntegrator

Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'


>> Entering Package Validation/TrackerDigis
>> Entering Package Validation/TrackerHits
>> Entering Package Validation/TrackerRecHits
>> Entering Package Validation/TrackingMCTruth
>> Compile sequence completed for CMSSW CMSSW_13_3_X_2023-09-28-1100
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1
+ eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_X_2023-09-28-1100/tmp/el8_amd64_gcc11/cache/log/src '||' 'true)'
++ scram build outputlog
>> Entering Package Alignment/APEEstimation
Entering library rule at src/Alignment/APEEstimation/plugins
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_X_2023-09-28-1100/src/Alignment/APEEstimation/plugins/ApeEstimator.cc

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da5d60/34961/summary.html
COMMIT: 3bb70bf
CMSSW: CMSSW_13_3_ROOT6_X_2023-09-27-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8723/34961/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_ROOT6_X_2023-09-27-2300/src/DQMOffline/Trigger/plugins/DQMGenericTnPClient.cc:1:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/gcc/11.4.1-30ebdc301ebd200f2ae0e3d880258e65/include/c++/11.4.1/bits/unique_ptr.h: In instantiation of 'void std::default_delete<_Tp>::operator()(_Tp*) const [with _Tp = RooFitResult]':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/gcc/11.4.1-30ebdc301ebd200f2ae0e3d880258e65/include/c++/11.4.1/bits/unique_ptr.h:361:17:   required from 'std::unique_ptr<_Tp, _Dp>::~unique_ptr() [with _Tp = RooFitResult; _Dp = std::default_delete]'
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/lcg/root/6.29.01-e72c8e35c9d6a8bb9738f0a080da38d4/include/RooAbsPdf.h:158:47:   required from 'RooFitResult* RooAbsPdf::fitTo(RooAbsData&, const CmdArgs_t& ...) [with CmdArgs_t = {}; RooFit::OwningPtr = RooFitResult*]'
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_ROOT6_X_2023-09-27-2300/src/DQMOffline/Trigger/plugins/GenericTnPFitter.h:316:21:   required from here
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/gcc/11.4.1-30ebdc301ebd200f2ae0e3d880258e65/include/c++/11.4.1/bits/unique_ptr.h:83:23: error: invalid application of 'sizeof' to incomplete type 'RooFitResult'
   83 |         static_assert(sizeof(_Tp)>0,
      |                       ^~~~~~~~~~~
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_ROOT6_X_2023-09-27-2300/src/DQMOffline/Trigger/plugins/FSQDiJetAve.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_ROOT6_X_2023-09-27-2300/src/DQMOffline/Trigger/plugins/HLTDQMMuonSelector.cc
gmake: *** [tmp/el8_amd64_gcc11/src/DQMOffline/Trigger/plugins/DQMOfflineTriggerPlugins/DQMGenericTnPClient.cc.o] Error 1

@iarspider
Copy link
Contributor Author

please test with cms-sw/cmssw#42899 for CMSSW_13_3_ROOT6_X

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da5d60/34980/summary.html
COMMIT: 3bb70bf
CMSSW: CMSSW_13_3_ROOT6_X_2023-09-28-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8723/34980/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da5d60/34980/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da5d60/34980/git-merge-result

Unit Tests

I found 2 errors in the following unit tests:

---> test CondToolsLHCInfoNewPopConTest had ERRORS
---> test BUFU_TEST had ERRORS

RelVals

----- Begin Fatal Exception 29-Sep-2023 23:58:52 CEST-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Processing global end Run run: 1
   [1] Calling method for module DQMGenericClient/'primaryVertexResolutionClient'
   Additional Info:
      [a] Fatal Root Error: @SUB=Minuit2
VariableMetricBuilder Initial matrix not pos.def.

----- End Fatal Exception -------------------------------------------------

@iarspider
Copy link
Contributor Author

Unit tests are known, but the relval failure is kind of new - the same error is tracked in cms-sw/cmssw#42029

@iarspider
Copy link
Contributor Author

please test with cms-sw/cmssw#42899 for CMSSW_13_3_ROOT6_X

@iarspider
Copy link
Contributor Author

please abort

@iarspider iarspider closed this Oct 2, 2023
@iarspider iarspider deleted the root-update-master-20230926 branch October 2, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
externals-pending orp-pending pending-signatures requires-external tests-pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iarspider @cmsbuild @smuzaffar