New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move to lhapdf6 6.1.4 and make a few fixes #945
Conversation
@mkirsano, Does this need to be updated for the additional pdfs available in 613/614? (in particular nnpdf3.0) |
You are right, Josh. I also added some automatization. |
Thanks, |
It is to be generated semiautomatically when lhapdf6 version is upgraded, on a computer with cvmfs. It still needs to be in the repository. |
+1 |
Can this one be moved forward? |
@@ -0,0 +1,26 @@ | |||
#TODO: check hat versions coincide | |||
|
|||
rm -f lhapdf6_makeLinks.file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate on what is happening here? Is this generating the lhapdf6_makeLinks.file file on the fly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding is that this script is run manually when preparing a new pull request. Then the version of lhapdf6_makeLinks which is actually used finally is the one in the repository/pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I now see it's listing /cvmfs… sigh… I personally do not like the idea of having in CMSDIST a random script running on a random machine using an hardcoded path, but I guess I'll live with it.. @Degano can you test this out and merge it?
+1 |
move to lhapdf6 6.1.4 and make a few fixes
No description provided.