Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to lhapdf6 6.1.4 and make a few fixes #945

Merged
2 commits merged into from Aug 26, 2014

Conversation

mkirsano
Copy link
Contributor

No description provided.

@bendavid
Copy link
Contributor

@mkirsano,
I see an explicit list of pdfs in
https://github.com/cms-sw/cmsdist/pull/945/files#diff-3aca08d05fafad4c82458388862b75c7L4

Does this need to be updated for the additional pdfs available in 613/614? (in particular nnpdf3.0)

@mkirsano
Copy link
Contributor Author

You are right, Josh. I also added some automatization.

@bendavid
Copy link
Contributor

Thanks,
If lhapdf6_makeLinks.file is now generated automatically, does there still need to be a copy in the repository?

@mkirsano
Copy link
Contributor Author

It is to be generated semiautomatically when lhapdf6 version is upgraded, on a computer with cvmfs. It still needs to be in the repository.

@bendavid
Copy link
Contributor

+1

@bendavid
Copy link
Contributor

Can this one be moved forward?
(We may need to backport this to 53x on short notice, so having it in 72x ASAP would be helpful)

@@ -0,0 +1,26 @@
#TODO: check hat versions coincide

rm -f lhapdf6_makeLinks.file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate on what is happening here? Is this generating the lhapdf6_makeLinks.file file on the fly?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that this script is run manually when preparing a new pull request. Then the version of lhapdf6_makeLinks which is actually used finally is the one in the repository/pull request.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I now see it's listing /cvmfs… sigh… I personally do not like the idea of having in CMSDIST a random script running on a random machine using an hardcoded path, but I guess I'll live with it.. @Degano can you test this out and merge it?

@ghost
Copy link

ghost commented Aug 26, 2014

+1
Tested compilation. Merging.

ghost pushed a commit that referenced this pull request Aug 26, 2014
move to lhapdf6 6.1.4 and make a few fixes
@ghost ghost merged commit 2c84cee into cms-sw:IB/CMSSW_7_2_X/stable Aug 26, 2014
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants