implement fillDescriptions for miscellaneous un-tested modules

cms-sw · Feb 4, 2023 · 081a945 · 081a945
1 parent e2be43e
commit 081a945
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 6 deletions.
diff --git a/Alignment/OfflineValidation/plugins/CosmicSplitterValidation.cc b/Alignment/OfflineValidation/plugins/CosmicSplitterValidation.cc
@@ -59,7 +59,9 @@
 class CosmicSplitterValidation : public edm::one::EDAnalyzer<edm::one::SharedResources> {
 public:
   explicit CosmicSplitterValidation(const edm::ParameterSet&);
-  ~CosmicSplitterValidation() override;
+  ~CosmicSplitterValidation() override = default;
+
+  static void fillDescriptions(edm::ConfigurationDescriptions& descriptions);
 
 private:
   void beginJob() override;
@@ -426,7 +428,18 @@ CosmicSplitterValidation::CosmicSplitterValidation(const edm::ParameterSet& iCon
     STAMuonsToken_ = iC.consumes<reco::MuonCollection>(edm::InputTag("STAMuons"));
 }
 
-CosmicSplitterValidation::~CosmicSplitterValidation() {}
+void CosmicSplitterValidation::fillDescriptions(edm::ConfigurationDescriptions& descriptions) {
+  edm::ParameterSetDescription desc;
+  desc.setComment("Validates alignment payloads by comparing split cosmic tracks parameters");
+  desc.addUntracked<int>("compressionSettings", -1);
+  desc.add<edm::InputTag>("splitTracks", edm::InputTag("FinalTrackRefitter", "", "splitter"));
+  desc.add<edm::InputTag>("splitGlobalMuons", edm::InputTag("muons", "", "splitter"));
+  desc.add<edm::InputTag>("originalTracks", edm::InputTag("FirstTrackRefitter", "", "splitter"));
+  desc.add<edm::InputTag>("originalGlobalMuons", edm::InputTag("muons", "", "Rec"));
+  desc.add<bool>("checkIfGolden", false);
+  desc.add<bool>("ifSplitMuons", false);
+  descriptions.addWithDefaultLabel(desc);
+}
 
 //
 // member functions

diff --git a/Alignment/OfflineValidation/plugins/Tracker_OldtoNewConverter.cc b/Alignment/OfflineValidation/plugins/Tracker_OldtoNewConverter.cc
@@ -3,7 +3,7 @@
 // Package:    Tracker_OldtoNewConverter.cc
 // Class:      Tracker_OldtoNewConverter
 //
-/**\class MuonGeometryIntoNtuples MuonGeometryIntoNtuples.cc Alignment/MuonGeometryIntoNtuples/src/MuonGeometryIntoNtuples.cc
+/**\class Tracker_OldtoNewConverter Tracker_OldtoNewConverter.cc Alignment/OfflineValidation/plugins/Tracker_OldtoNewConverter.cc
 
  Description: <one line class summary>
 
@@ -38,7 +38,9 @@
 class Tracker_OldtoNewConverter : public edm::one::EDAnalyzer<> {
 public:
   explicit Tracker_OldtoNewConverter(const edm::ParameterSet&);
-  ~Tracker_OldtoNewConverter() override;
+  ~Tracker_OldtoNewConverter() override = default;
+
+  static void fillDescriptions(edm::ConfigurationDescriptions& descriptions);
 
 private:
   void beginJob() override;
@@ -106,12 +108,21 @@ Tracker_OldtoNewConverter::Tracker_OldtoNewConverter(const edm::ParameterSet& iC
   m_treeName = iConfig.getUntrackedParameter<std::string>("treeName");
 }
 
-Tracker_OldtoNewConverter::~Tracker_OldtoNewConverter() {}
-
 //
 // member functions
 //
 
+void Tracker_OldtoNewConverter::fillDescriptions(edm::ConfigurationDescriptions& descriptions) {
+  edm::ParameterSetDescription desc;
+  desc.setComment("Converts tracker geometry comparison trees");
+  desc.addUntracked<std::string>("conversionType", {});
+  desc.addUntracked<std::string>("inputFile", {});
+  desc.addUntracked<std::string>("outputFile", {});
+  desc.addUntracked<std::string>("textFile", {});
+  desc.addUntracked<std::string>("treeName", {});
+  descriptions.addWithDefaultLabel(desc);
+}
+
 // ------------ method called to for each event  ------------
 void Tracker_OldtoNewConverter::analyze(const edm::Event& iEvent, const edm::EventSetup& iSetup) {}