Skip to content

Commit

Permalink
Merge pull request #29654 from fwyzard/branch_lintBuildFile_CommonTools
Browse files Browse the repository at this point in the history
Clean up BuildFiles under CommonTools/
  • Loading branch information
cmsbuild committed May 6, 2020
2 parents b0f1b66 + 03cf3db commit 1e86f50
Show file tree
Hide file tree
Showing 31 changed files with 240 additions and 251 deletions.
6 changes: 3 additions & 3 deletions CommonTools/BaseParticlePropagator/BuildFile.xml
@@ -1,5 +1,5 @@
<use name="DataFormats/Math"/>
<use name="rootmath"/>
<use name="DataFormats/Math"/>
<use name="rootmath"/>
<export>
<lib name="1"/>
<lib name="1"/>
</export>
2 changes: 1 addition & 1 deletion CommonTools/BaseParticlePropagator/test/BuildFile.xml
@@ -1,4 +1,4 @@
<bin file="makeMuon_catch2.cc" name="TestCommonToolsBaseParticlePropagator">
<use name="catch2"/>
<use name="CommonTools/BaseParticlePropagator"/>
<use name="CommonTools/BaseParticlePropagator"/>
</bin>
10 changes: 5 additions & 5 deletions CommonTools/CandAlgos/BuildFile.xml
@@ -1,7 +1,7 @@
<use name="SimGeneral/HepPDTRecord"/>
<use name="FWCore/Framework"/>
<use name="FWCore/ParameterSet"/>
<use name="DataFormats/PatCandidates"/>
<use name="SimGeneral/HepPDTRecord"/>
<use name="FWCore/Framework"/>
<use name="FWCore/ParameterSet"/>
<use name="DataFormats/PatCandidates"/>
<export>
<lib name="1"/>
<lib name="1"/>
</export>
18 changes: 9 additions & 9 deletions CommonTools/CandAlgos/plugins/BuildFile.xml
@@ -1,12 +1,12 @@
<export>
</export>
<library name="CommonToolsCandAlgos_plugins" file="*.cc">
<use name="FWCore/Framework"/>
<use name="FWCore/ParameterSet"/>
<use name="DataFormats/Candidate"/>
<use name="DataFormats/HepMCCandidate"/>
<use name="CommonTools/UtilAlgos"/>
<use name="CommonTools/Utils"/>
<use name="CommonTools/CandAlgos"/>
<use name="CommonTools/CandUtils"/>
<library name="CommonToolsCandAlgos_plugins" file="*.cc">
<use name="FWCore/Framework"/>
<use name="FWCore/ParameterSet"/>
<use name="DataFormats/Candidate"/>
<use name="DataFormats/HepMCCandidate"/>
<use name="CommonTools/UtilAlgos"/>
<use name="CommonTools/Utils"/>
<use name="CommonTools/CandAlgos"/>
<use name="CommonTools/CandUtils"/>
</library>
4 changes: 2 additions & 2 deletions CommonTools/CandUtils/BuildFile.xml
@@ -1,4 +1,4 @@
<use name="DataFormats/Candidate"/>
<use name="DataFormats/Candidate"/>
<export>
<lib name="1"/>
<lib name="1"/>
</export>
6 changes: 3 additions & 3 deletions CommonTools/CandUtils/test/BuildFile.xml
@@ -1,4 +1,4 @@
<bin name="testCommonToolsCandUtils" file="testMakeCompositeCandidate.cc,testMakeCompositePtrCandidate.cc,testRunner.cpp ">
<use name="CommonTools/CandUtils"/>
<use name="cppunit"/>
<bin name="testCommonToolsCandUtils" file="testMakeCompositeCandidate.cc,testMakeCompositePtrCandidate.cc,testRunner.cpp ">
<use name="CommonTools/CandUtils"/>
<use name="cppunit"/>
</bin>
6 changes: 3 additions & 3 deletions CommonTools/Clustering1D/BuildFile.xml
@@ -1,5 +1,5 @@
<use name="DataFormats/GeometryCommonDetAlgo"/>
<use name="FWCore/Utilities"/>
<use name="DataFormats/GeometryCommonDetAlgo"/>
<use name="FWCore/Utilities"/>
<export>
<lib name="1"/>
<lib name="1"/>
</export>
6 changes: 3 additions & 3 deletions CommonTools/Clustering1D/test/BuildFile.xml
@@ -1,4 +1,4 @@
<use name="CommonTools/Clustering1D"/>
<use name="FWCore/Framework"/>
<bin file="ClusteringTest.cpp">
<use name="CommonTools/Clustering1D"/>
<use name="FWCore/Framework"/>
<bin file="ClusteringTest.cpp">
</bin>
15 changes: 7 additions & 8 deletions CommonTools/MVAUtils/BuildFile.xml
@@ -1,10 +1,9 @@
<use name="CondFormats/EgammaObjects"/>
<use name="FWCore/ParameterSet"/>
<use name="FWCore/Utilities"/>
<use name="CondFormats/DataRecord"/>
<use name="roottmva"/>
<use name="tinyxml2"/>

<use name="CondFormats/EgammaObjects"/>
<use name="FWCore/ParameterSet"/>
<use name="FWCore/Utilities"/>
<use name="CondFormats/DataRecord"/>
<use name="roottmva"/>
<use name="tinyxml2"/>
<export>
<lib name="1"/>
<lib name="1"/>
</export>
18 changes: 9 additions & 9 deletions CommonTools/ParticleFlow/BuildFile.xml
@@ -1,11 +1,11 @@
<use name="DataFormats/Common"/>
<use name="DataFormats/ParticleFlowCandidate"/>
<use name="DataFormats/EgammaCandidates"/>
<use name="DataFormats/METReco"/>
<use name="DataFormats/JetReco"/>
<use name="DataFormats/PatCandidates"/>
<use name="rootmath"/>
<use name="FWCore/ParameterSet"/>
<use name="DataFormats/Common"/>
<use name="DataFormats/ParticleFlowCandidate"/>
<use name="DataFormats/EgammaCandidates"/>
<use name="DataFormats/METReco"/>
<use name="DataFormats/JetReco"/>
<use name="DataFormats/PatCandidates"/>
<use name="rootmath"/>
<use name="FWCore/ParameterSet"/>
<export>
<lib name="1"/>
<lib name="1"/>
</export>
34 changes: 17 additions & 17 deletions CommonTools/ParticleFlow/plugins/BuildFile.xml
@@ -1,20 +1,20 @@
<export>
</export>
<library name="CommonToolsParticleFlow_plugins" file="*.cc">
<use name="DataFormats/ParticleFlowCandidate"/>
<use name="DataFormats/JetReco"/>
<use name="DataFormats/TauReco"/>
<use name="DataFormats/METReco"/>
<use name="DataFormats/TrackReco"/>
<use name="DataFormats/VertexReco"/>
<use name="PhysicsTools/IsolationAlgos"/>
<use name="FWCore/Framework"/>
<use name="FWCore/MessageLogger"/>
<use name="FWCore/ParameterSet"/>
<use name="JetMETCorrections/Objects"/>
<use name="JetMETCorrections/JetCorrector"/>
<use name="CommonTools/Utils"/>
<use name="CommonTools/ParticleFlow"/>
<use name="CalibFormats/HcalObjects"/>
<use name="Geometry/HcalTowerAlgo"/>
<library name="CommonToolsParticleFlow_plugins" file="*.cc">
<use name="DataFormats/ParticleFlowCandidate"/>
<use name="DataFormats/JetReco"/>
<use name="DataFormats/TauReco"/>
<use name="DataFormats/METReco"/>
<use name="DataFormats/TrackReco"/>
<use name="DataFormats/VertexReco"/>
<use name="PhysicsTools/IsolationAlgos"/>
<use name="FWCore/Framework"/>
<use name="FWCore/MessageLogger"/>
<use name="FWCore/ParameterSet"/>
<use name="JetMETCorrections/Objects"/>
<use name="JetMETCorrections/JetCorrector"/>
<use name="CommonTools/Utils"/>
<use name="CommonTools/ParticleFlow"/>
<use name="CalibFormats/HcalObjects"/>
<use name="Geometry/HcalTowerAlgo"/>
</library>
17 changes: 8 additions & 9 deletions CommonTools/ParticleFlow/test/BuildFile.xml
@@ -1,10 +1,9 @@
<library name="CommonToolsParticleFlowTest" file="PFIsoReaderDemo.cc">
<use name="DataFormats/Common"/>
<use name="DataFormats/EgammaCandidates"/>
<use name="FWCore/Framework"/>
<use name="FWCore/MessageLogger"/>
<use name="FWCore/ParameterSet"/>
<use name="PhysicsTools/UtilAlgos"/>

<flags EDM_PLUGIN="1"/>
<library name="CommonToolsParticleFlowTest" file="PFIsoReaderDemo.cc">
<use name="DataFormats/Common"/>
<use name="DataFormats/EgammaCandidates"/>
<use name="FWCore/Framework"/>
<use name="FWCore/MessageLogger"/>
<use name="FWCore/ParameterSet"/>
<use name="PhysicsTools/UtilAlgos"/>
<flags EDM_PLUGIN="1"/>
</library>
15 changes: 7 additions & 8 deletions CommonTools/PileupAlgos/BuildFile.xml
@@ -1,10 +1,9 @@
<use name="DataFormats/Common"/>
<use name="DataFormats/ParticleFlowCandidate"/>
<use name="FWCore/ParameterSet"/>
<use name="root"/>

<use name="rootcore"/>
<use name="fastjet"/>
<use name="DataFormats/Common"/>
<use name="DataFormats/ParticleFlowCandidate"/>
<use name="FWCore/ParameterSet"/>
<use name="root"/>
<use name="rootcore"/>
<use name="fastjet"/>
<export>
<lib name="1"/>
<lib name="1"/>
</export>
24 changes: 12 additions & 12 deletions CommonTools/PileupAlgos/plugins/BuildFile.xml
@@ -1,15 +1,15 @@
<export>
</export>
<library name="CommonToolsPileupAlgos_plugins" file="*.cc">
<use name="DataFormats/ParticleFlowCandidate"/>
<use name="DataFormats/JetReco"/>
<use name="FWCore/Framework"/>
<use name="FWCore/MessageLogger"/>
<use name="FWCore/ParameterSet"/>
<use name="JetMETCorrections/Objects"/>
<use name="CommonTools/Utils"/>
<use name="CommonTools/ParticleFlow"/>
<use name="CommonTools/PileupAlgos"/>
<use name="fastjet"/>
<use name="fastjet-contrib"/>
<library name="CommonToolsPileupAlgos_plugins" file="*.cc">
<use name="DataFormats/ParticleFlowCandidate"/>
<use name="DataFormats/JetReco"/>
<use name="FWCore/Framework"/>
<use name="FWCore/MessageLogger"/>
<use name="FWCore/ParameterSet"/>
<use name="JetMETCorrections/Objects"/>
<use name="CommonTools/Utils"/>
<use name="CommonTools/ParticleFlow"/>
<use name="CommonTools/PileupAlgos"/>
<use name="fastjet"/>
<use name="fastjet-contrib"/>
</library>
37 changes: 18 additions & 19 deletions CommonTools/RecoAlgos/BuildFile.xml
@@ -1,21 +1,20 @@
<use name="SimGeneral/HepPDTRecord"/>
<use name="FWCore/Framework"/>
<use name="FWCore/ParameterSet"/>
<use name="DataFormats/TrackReco"/>
<use name="DataFormats/MuonReco"/>
<use name="DataFormats/TrackingRecHit"/>
<use name="DataFormats/SiStripCluster"/>
<use name="DataFormats/SiPixelCluster"/>
<use name="DataFormats/TrackerRecHit2D"/>
<use name="DataFormats/METReco"/>
<use name="DataFormats/RecoCandidate"/>
<use name="DataFormats/Candidate"/>
<use name="DataFormats/VertexReco"/>
<use name="TrackingTools/Records"/>
<use name="TrackingTools/IPTools"/>
<use name="TrackingTools/TransientTrack"/>
<use name="fastjet"/>

<use name="SimGeneral/HepPDTRecord"/>
<use name="FWCore/Framework"/>
<use name="FWCore/ParameterSet"/>
<use name="DataFormats/TrackReco"/>
<use name="DataFormats/MuonReco"/>
<use name="DataFormats/TrackingRecHit"/>
<use name="DataFormats/SiStripCluster"/>
<use name="DataFormats/SiPixelCluster"/>
<use name="DataFormats/TrackerRecHit2D"/>
<use name="DataFormats/METReco"/>
<use name="DataFormats/RecoCandidate"/>
<use name="DataFormats/Candidate"/>
<use name="DataFormats/VertexReco"/>
<use name="TrackingTools/Records"/>
<use name="TrackingTools/IPTools"/>
<use name="TrackingTools/TransientTrack"/>
<use name="fastjet"/>
<export>
<lib name="1"/>
<lib name="1"/>
</export>
42 changes: 21 additions & 21 deletions CommonTools/RecoAlgos/plugins/BuildFile.xml
@@ -1,24 +1,24 @@
<export>
</export>
<library name="CommonToolsRecoAlgos_plugins" file="*.cc">
<use name="MagneticField/Engine"/>
<use name="FWCore/Framework"/>
<use name="FWCore/ParameterSet"/>
<use name="DataFormats/RecoCandidate"/>
<use name="DataFormats/BTauReco"/>
<use name="DataFormats/EgammaCandidates"/>
<use name="DataFormats/EgammaReco"/>
<use name="DataFormats/MuonReco"/>
<use name="DataFormats/JetReco"/>
<use name="DataFormats/METReco"/>
<use name="DataFormats/PatCandidates"/>
<use name="DataFormats/HcalRecHit"/>
<use name="SimDataFormats/TrackingAnalysis"/>
<use name="TrackingTools/PatternTools"/>
<use name="CommonTools/Utils"/>
<use name="CommonTools/RecoAlgos"/>
<use name="MagneticField/Records"/>
<use name="Geometry/Records"/>
<use name="Geometry/TrackerGeometryBuilder"/>
<use name="JetMETCorrections/JetCorrector"/>
<library name="CommonToolsRecoAlgos_plugins" file="*.cc">
<use name="MagneticField/Engine"/>
<use name="FWCore/Framework"/>
<use name="FWCore/ParameterSet"/>
<use name="DataFormats/RecoCandidate"/>
<use name="DataFormats/BTauReco"/>
<use name="DataFormats/EgammaCandidates"/>
<use name="DataFormats/EgammaReco"/>
<use name="DataFormats/MuonReco"/>
<use name="DataFormats/JetReco"/>
<use name="DataFormats/METReco"/>
<use name="DataFormats/PatCandidates"/>
<use name="DataFormats/HcalRecHit"/>
<use name="SimDataFormats/TrackingAnalysis"/>
<use name="TrackingTools/PatternTools"/>
<use name="CommonTools/Utils"/>
<use name="CommonTools/RecoAlgos"/>
<use name="MagneticField/Records"/>
<use name="Geometry/Records"/>
<use name="Geometry/TrackerGeometryBuilder"/>
<use name="JetMETCorrections/JetCorrector"/>
</library>
6 changes: 3 additions & 3 deletions CommonTools/RecoAlgos/test/BuildFile.xml
@@ -1,5 +1,5 @@
<use name="cppunit"/>
<use name="CommonTools/RecoAlgos"/>
<bin file="FKDTree_t.cpp">
<use name="cppunit"/>
<use name="CommonTools/RecoAlgos"/>
<bin file="FKDTree_t.cpp">

</bin>
43 changes: 21 additions & 22 deletions CommonTools/RecoUtils/BuildFile.xml
@@ -1,24 +1,23 @@
<use name="DataFormats/Common"/>
<use name="DataFormats/EgammaCandidates"/>
<use name="DataFormats/L1GlobalTrigger"/>
<use name="DataFormats/RecoCandidate"/>
<use name="DataFormats/Scalers"/>
<use name="DataFormats/TrackReco"/>
<use name="DataFormats/VertexReco"/>
<use name="DataFormats/ParticleFlowReco"/>
<use name="DataFormats/ParticleFlowCandidate"/>
<use name="L1Trigger/GlobalTriggerAnalyzer"/>
<use name="MagneticField/Records"/>
<use name="MagneticField/Engine"/>
<use name="HLTrigger/HLTcore"/>
<use name="RecoEgamma/EgammaTools"/>
<use name="RecoVertex/KinematicFit"/>
<use name="RecoVertex/KinematicFitPrimitives"/>

<use name="TrackingTools/TransientTrack"/>
<use name="TrackingTools/IPTools"/>
<use name="TrackingTools/Records"/>
<use name="FWCore/Framework"/>
<use name="DataFormats/Common"/>
<use name="DataFormats/EgammaCandidates"/>
<use name="DataFormats/L1GlobalTrigger"/>
<use name="DataFormats/RecoCandidate"/>
<use name="DataFormats/Scalers"/>
<use name="DataFormats/TrackReco"/>
<use name="DataFormats/VertexReco"/>
<use name="DataFormats/ParticleFlowReco"/>
<use name="DataFormats/ParticleFlowCandidate"/>
<use name="L1Trigger/GlobalTriggerAnalyzer"/>
<use name="MagneticField/Records"/>
<use name="MagneticField/Engine"/>
<use name="HLTrigger/HLTcore"/>
<use name="RecoEgamma/EgammaTools"/>
<use name="RecoVertex/KinematicFit"/>
<use name="RecoVertex/KinematicFitPrimitives"/>
<use name="TrackingTools/TransientTrack"/>
<use name="TrackingTools/IPTools"/>
<use name="TrackingTools/Records"/>
<use name="FWCore/Framework"/>
<export>
<lib name="1"/>
<lib name="1"/>
</export>
6 changes: 3 additions & 3 deletions CommonTools/RecoUtils/plugins/BuildFile.xml
Expand Up @@ -5,6 +5,6 @@
<use name="DataFormats/Common"/>
<use name="DataFormats/TrackReco"/>
<use name="DataFormats/EgammaCandidates"/>
<library file="*.cc" name="PFPUAssoMapPlugins">
<flags EDM_PLUGIN="1"/>
</library>
<library file="*.cc" name="PFPUAssoMapPlugins">
<flags EDM_PLUGIN="1"/>
</library>
10 changes: 5 additions & 5 deletions CommonTools/Statistics/BuildFile.xml
@@ -1,7 +1,7 @@
<export>
<lib name="1"/>
<lib name="1"/>
</export>
<use name="clhep"/>
<use name="boost"/>
<use name="DataFormats/CLHEP"/>
<use name="FWCore/MessageLogger"/>
<use name="clhep"/>
<use name="boost"/>
<use name="DataFormats/CLHEP"/>
<use name="FWCore/MessageLogger"/>

0 comments on commit 1e86f50

Please sign in to comment.