Merge pull request #25320 from MilanoBicocca-pix/fix_fail_d0phi_103X

[Backport] Discard Beamspot fit results when d0-phi fit status is unknown
cms-sw · Nov 25, 2018 · 27ca9fb · 27ca9fb
2 parents 9032195 + 978f698
commit 27ca9fb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/RecoVertex/BeamSpotProducer/src/BSFitter.cc b/RecoVertex/BeamSpotProducer/src/BSFitter.cc
@@ -588,7 +588,7 @@ reco::BeamSpot BSFitter::Fit_d0phi() {
 	//std::cout << "got function" << std::endl;
 	if (status){
 	  //edm::LogError("NoBeamSpotFit")<<"gaussian fit failed. no BS d0 fit";
-
+	  goodfit = false;
 	  return reco::BeamSpot();
 	}
 	double fpar[2] = {fgaus.GetParameter(1), fgaus.GetParameter(2) };

diff --git a/RecoVertex/BeamSpotProducer/src/BeamFitter.cc b/RecoVertex/BeamSpotProducer/src/BeamFitter.cc
@@ -530,7 +530,7 @@ bool BeamFitter::runFitterNoTxt() {
     h1z = (TH1F*) myalgo->GetVzHisto();
 
     delete myalgo;
-    if ( fbeamspot.type() != 0 ) {// save all results except for Fake (all 0.)
+    if ( fbeamspot.type() > 0 ) {// save all results except for Fake and Unknown(all 0.)
       fit_ok = true;
       if (saveBeamFit_){
 	fx = fbeamspot.x0();