Merge pull request #29598 from smuzaffar/llvm10-warnings-sim

[LLVM10] Fixing compilation warnings for SIM
cms-sw · May 1, 2020 · 30ddd9a · 30ddd9a
2 parents 372abd5 + 9e16e7f
commit 30ddd9a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/SimGeneral/CaloAnalysis/plugins/PreMixingCaloParticleWorker.cc b/SimGeneral/CaloAnalysis/plugins/PreMixingCaloParticleWorker.cc
@@ -121,7 +121,7 @@ void PreMixingCaloParticleWorker::add(const SimClusterCollection &clusters,
   }
 
   // Add energies
-  for (const auto elem : energy) {
+  for (const auto &elem : energy) {
     totalEnergy_[elem.first] += elem.second;
   }
 }

diff --git a/SimTracker/TrackerMaterialAnalysis/plugins/dd4hep/DD4hep_Listgroups.cc b/SimTracker/TrackerMaterialAnalysis/plugins/dd4hep/DD4hep_Listgroups.cc
@@ -257,7 +257,7 @@ void DD4hep_ListGroups::analyze(const edm::Event &evt, const edm::EventSetup &se
     bool firstChild = fv1.firstChild();
 
     for (const auto j : fv1.specpars()) {
-      for (const auto k : j->paths) {
+      for (const auto &k : j->paths) {
         if (firstChild) {
           std::vector<std::vector<cms::Node *>> children = fv1.children(k);
           for (auto const &path : children) {