Merge pull request #19740 from folguera/PixDQM_AddInactiveHits

Adding inactive hit maps
cms-sw · Jul 17, 2017 · 3b78078 · 3b78078
2 parents 17e2441 + 465d4a7
commit 3b78078
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 3 deletions.
diff --git a/DQM/SiPixelPhase1TrackEfficiency/interface/SiPixelPhase1TrackEfficiency.h b/DQM/SiPixelPhase1TrackEfficiency/interface/SiPixelPhase1TrackEfficiency.h
@@ -17,6 +17,7 @@ class SiPixelPhase1TrackEfficiency : public SiPixelPhase1Base {
   enum {
     VALID,
     MISSING,
+    INACTIVE,
     EFFICIENCY,
     VERTICES
   };

diff --git a/DQM/SiPixelPhase1TrackEfficiency/python/SiPixelPhase1TrackEfficiency_cfi.py b/DQM/SiPixelPhase1TrackEfficiency/python/SiPixelPhase1TrackEfficiency_cfi.py
@@ -24,6 +24,27 @@
   )
 )
 
+SiPixelPhase1TrackEfficiencyInactive = DefaultHistoTrack.clone(
+  name = "inactive",
+  title = "Inactive Hits",
+  xlabel = "inactive hits",
+  dimensions = 0,
+
+  specs = VPSet(
+    StandardSpecifications1D_Num,
+    StandardSpecification2DProfile_Num,
+
+    Specification().groupBy("PXBarrel/PXLayer/Event") #this will produce inclusive counts per Layer/Disk
+                             .reduce("COUNT")    
+                             .groupBy("PXBarrel/PXLayer")
+                             .save(nbins=100, xmin=0, xmax=100),
+    Specification().groupBy("PXForward/PXDisk/Event")
+                             .reduce("COUNT")    
+                             .groupBy("PXForward/PXDisk/")
+                             .save(nbins=100, xmin=0, xmax=100),
+  )
+)
+
 SiPixelPhase1TrackEfficiencyMissing = DefaultHistoTrack.clone(
   name = "missing",
   title = "Missing Hits",
@@ -79,6 +100,7 @@
 SiPixelPhase1TrackEfficiencyConf = cms.VPSet(
   SiPixelPhase1TrackEfficiencyValid,
   SiPixelPhase1TrackEfficiencyMissing,
+  SiPixelPhase1TrackEfficiencyInactive,
   SiPixelPhase1TrackEfficiencyEfficiency,
   SiPixelPhase1TrackEfficiencyVertices
 )

diff --git a/DQM/SiPixelPhase1TrackEfficiency/src/SiPixelPhase1TrackEfficiency.cc b/DQM/SiPixelPhase1TrackEfficiency/src/SiPixelPhase1TrackEfficiency.cc
@@ -98,7 +98,8 @@ void SiPixelPhase1TrackEfficiency::analyze(const edm::Event& iEvent, const edm::
 
       bool isHitValid   = hit->getType()==TrackingRecHit::valid;
       bool isHitMissing = hit->getType()==TrackingRecHit::missing;
-
+      bool isHitInactive = hit->getType()==TrackingRecHit::inactive;
+
       /*
       const SiPixelRecHit* pixhit = dynamic_cast<const SiPixelRecHit*>(hit);
       const PixelGeomDetUnit* geomdetunit = dynamic_cast<const PixelGeomDetUnit*> ( tracker->idToDet(id) );
@@ -126,10 +127,14 @@ void SiPixelPhase1TrackEfficiency::analyze(const edm::Event& iEvent, const edm::
         histo[MISSING].fill(id, &iEvent);
         histo[EFFICIENCY].fill(0, id, &iEvent);
       }
+      if (isHitInactive)   {
+        histo[INACTIVE].fill(id, &iEvent);
+      }
     }
   }
-histo[VALID  ].executePerEventHarvesting(&iEvent);
-histo[MISSING].executePerEventHarvesting(&iEvent);
+  histo[VALID   ].executePerEventHarvesting(&iEvent);
+  histo[MISSING ].executePerEventHarvesting(&iEvent);
+  histo[INACTIVE].executePerEventHarvesting(&iEvent);
 }
 
 DEFINE_FWK_MODULE(SiPixelPhase1TrackEfficiency);