Merge pull request #37253 from gk199/L1emulator_ASANfix

L1T ASAN heap-buffer-overflow fix resulting from PR #36919
cms-sw · Mar 20, 2022 · 4145e52 · 4145e52
2 parents 462cc82 + 24cd926
commit 4145e52
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/EventFilter/L1TRawToDigi/plugins/implementations_stage2/CaloLayer1Packer.cc b/EventFilter/L1TRawToDigi/plugins/implementations_stage2/CaloLayer1Packer.cc
@@ -108,11 +108,11 @@ namespace l1t {
             HcalTrigTowerDetId id(cEta, cPhi);
             const auto tp = hcalTPGs->find(id);
 
-            int fg_bits = 0;
-            for (int index = 0; index < 6; index++)
-              fg_bits += tp->SOI_fineGrain(index) << index;
-
             if (tp != hcalTPGs->end()) {
+              uint32_t fg_bits = 0;
+              for (int index = 0; index < 6; index++)
+                fg_bits |= tp->SOI_fineGrain(index) << index;
+
               ctp7Data.setET(cType, negativeEta, iEta, iPhi, tp->SOI_compressedEt());
               ctp7Data.setFB(cType, negativeEta, iEta, iPhi, fg_bits);
             }