Skip to content

Commit

Permalink
Merge pull request #671 from deguio/declareConsumesForCorePackages
Browse files Browse the repository at this point in the history
declare consumes for DQM core packages
  • Loading branch information
davidlt committed Sep 8, 2013
2 parents 77672c4 + c8fdefe commit 8045748
Show file tree
Hide file tree
Showing 8 changed files with 49 additions and 24 deletions.
11 changes: 5 additions & 6 deletions DQMServices/Components/plugins/DQMLumiMonitor.cc
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ DQMLumiMonitor::DQMLumiMonitor( const edm::ParameterSet& ps ) : parameters_(ps)

moduleName_ = parameters_.getParameter<std::string>("ModuleName");
folderName_ = parameters_.getParameter<std::string>("FolderName");
pixelClusterInputTag_= parameters_.getParameter<edm::InputTag>("PixelClusterInputTag");
lumiRecordName_ = parameters_.getParameter<std::string>("LumiRecordName");
pixelClusterInputTag_= consumes<edmNew::DetSetVector<SiPixelCluster> >(parameters_.getParameter<edm::InputTag>("PixelClusterInputTag"));
lumiRecordName_ = consumes<LumiSummary,edm::InLumi>(parameters_.getParameter<std::string>("LumiRecordName"));

nClusME_ = 0;
nClusVsLSME_ = 0;
Expand Down Expand Up @@ -91,11 +91,10 @@ void DQMLumiMonitor::analyze(edm::Event const& iEvent, edm::EventSetup const& iS

//Access Pixel Clusters
edm::Handle< edmNew::DetSetVector<SiPixelCluster> > siPixelClusters;
// edm::Handle< SiPixelClusterCollectionNew > siPixelClusters;
iEvent.getByLabel(pixelClusterInputTag_, siPixelClusters);
iEvent.getByToken(pixelClusterInputTag_, siPixelClusters);

if(!siPixelClusters.isValid()) {
edm::LogError("PixelLumiMonotor") << "Could not find Cluster Collection " << pixelClusterInputTag_;
edm::LogError("PixelLumiMonotor") << "Could not find Cluster Collection ";
return;
}
unsigned int nClusterPix = (*siPixelClusters).dataSize();
Expand All @@ -111,7 +110,7 @@ void DQMLumiMonitor::endLuminosityBlock(edm::LuminosityBlock const& lumiBlock, e

// Access Lumi Summary
edm::Handle<LumiSummary> lumiSummary_;
lumiBlock.getByLabel(lumiRecordName_, lumiSummary_);
lumiBlock.getByToken(lumiRecordName_, lumiSummary_);
if(lumiSummary_->isValid()){
intLumi_ = lumiSummary_->intgDelLumi();
edm::LogInfo("PixelLumiMonotor") <<" Luminosity in this Lumi Section " << intLumi_ ;
Expand Down
10 changes: 7 additions & 3 deletions DQMServices/Components/plugins/DQMLumiMonitor.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,16 @@
#include <vector>
#include <map>

#include <FWCore/Framework/interface/EDAnalyzer.h>
#include "FWCore/Framework/interface/EDAnalyzer.h"
#include "FWCore/ParameterSet/interface/ParameterSet.h"
#include "DQMServices/Core/interface/DQMStore.h"
#include "DQMServices/Core/interface/MonitorElement.h"
#include "HLTrigger/HLTcore/interface/HLTConfigProvider.h"

//DataFormats
#include "DataFormats/Luminosity/interface/LumiSummary.h"
#include "DataFormats/SiPixelCluster/interface/SiPixelCluster.h"

//
// class declaration
//
Expand All @@ -46,8 +50,8 @@ class DQMLumiMonitor : public edm::EDAnalyzer {

std::string moduleName_;
std::string folderName_;
edm::InputTag pixelClusterInputTag_;
std::string lumiRecordName_;
edm::EDGetTokenT<edmNew::DetSetVector<SiPixelCluster> > pixelClusterInputTag_;
edm::EDGetTokenT<LumiSummary> lumiRecordName_;

DQMStore * dbe_;

Expand Down
12 changes: 7 additions & 5 deletions DQMServices/Components/src/DQMDcsInfo.cc
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,11 @@ DQMDcsInfo::DQMDcsInfo(const edm::ParameterSet& ps)

dbe_ = edm::Service<DQMStore>().operator->();

subsystemname_ = parameters_.getUntrackedParameter<std::string>("subSystemFolder", "Info") ;
dcsinfofolder_ = parameters_.getUntrackedParameter<std::string>("dcsInfoFolder", "DcsInfo") ;

subsystemname_ = parameters_.getUntrackedParameter<std::string>("subSystemFolder", "Info") ;
dcsinfofolder_ = parameters_.getUntrackedParameter<std::string>("dcsInfoFolder", "DcsInfo") ;
gtCollection_ = consumes<L1GlobalTriggerReadoutRecord>(parameters_.getUntrackedParameter<std::string>("gtCollection","gtDigis"));
dcsStatusCollection_ = consumes<DcsStatusCollection>(parameters_.getUntrackedParameter<std::string>("dcsStatusCollection","scalersRawToDigi"));

// initialize
for (int i=0;i<25;i++) dcs[i]=true;
}
Expand Down Expand Up @@ -87,7 +89,7 @@ DQMDcsInfo::makeDcsInfo(const edm::Event& e)
{

edm::Handle<DcsStatusCollection> dcsStatus;
if ( ! e.getByLabel("scalersRawToDigi", dcsStatus) )
if ( ! e.getByToken(dcsStatusCollection_, dcsStatus) )
{
for (int i=0;i<24;i++) dcs[i]=false;
return;
Expand Down Expand Up @@ -137,7 +139,7 @@ DQMDcsInfo::makeGtInfo(const edm::Event& e)
{

edm::Handle<L1GlobalTriggerReadoutRecord> gtrr_handle;
if ( ! e.getByLabel("gtDigis", gtrr_handle) )
if ( ! e.getByToken(gtCollection_, gtrr_handle) )
{
dcs[24]=false; // info not available: set to false
return;
Expand Down
6 changes: 6 additions & 0 deletions DQMServices/Components/src/DQMDcsInfo.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@
#include <DQMServices/Core/interface/DQMStore.h>
#include <DQMServices/Core/interface/MonitorElement.h>

//DataFormats
#include "DataFormats/Scalers/interface/DcsStatus.h"
#include "DataFormats/L1GlobalTrigger/interface/L1GlobalTriggerReadoutRecord.h"

class DQMDcsInfo: public edm::EDAnalyzer{

public:
Expand Down Expand Up @@ -46,6 +50,8 @@ class DQMDcsInfo: public edm::EDAnalyzer{
edm::ParameterSet parameters_;
std::string subsystemname_;
std::string dcsinfofolder_;
edm::EDGetTokenT<L1GlobalTriggerReadoutRecord> gtCollection_;
edm::EDGetTokenT<DcsStatusCollection> dcsStatusCollection_;

bool dcs[25];
// histograms
Expand Down
8 changes: 5 additions & 3 deletions DQMServices/Components/src/DQMMessageLogger.cc
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,10 @@ DQMMessageLogger::DQMMessageLogger(const ParameterSet& parameters) {

//Get from cfg file
categories_vector = parameters.getParameter< vector<string> >("Categories");
directoryName = parameters.getParameter<string>("Directory");

directoryName = parameters.getParameter<string>("Directory");
errorSummary_ = consumes<std::vector<edm::ErrorSummaryEntry> >(parameters.getUntrackedParameter<std::string>("errorSummary","logErrorHarvester"));


}

DQMMessageLogger::~DQMMessageLogger() {
Expand Down Expand Up @@ -146,7 +148,7 @@ void DQMMessageLogger::analyze(const Event& iEvent, const EventSetup& iSetup) {

// Take the ErrorSummaryEntry container
Handle<std::vector<edm::ErrorSummaryEntry> > errors;
iEvent.getByLabel("logErrorHarvester",errors);
iEvent.getByToken(errorSummary_,errors);
// Check that errors is valid
if(!errors.isValid()){ return; }
// Compare severity level of error with ELseveritylevel instance el : "-e" should be the lowest error
Expand Down
1 change: 1 addition & 0 deletions DQMServices/Components/src/DQMMessageLogger.h
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ class DQMMessageLogger : public edm::EDAnalyzer {
// from parameters
std::vector<std::string> categories_vector;
std::string directoryName;
edm::EDGetTokenT<std::vector<edm::ErrorSummaryEntry> > errorSummary_;

//The histos
MonitorElement *categories_errors;
Expand Down
17 changes: 10 additions & 7 deletions DQMServices/Components/src/DQMProvInfo.cc
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,13 @@ DQMProvInfo::DQMProvInfo(const edm::ParameterSet& ps){
parameters_ = ps;

dbe_ = edm::Service<DQMStore>().operator->();
globalTag_ = "MODULE::DEFAULT";
runType_ = parameters_.getUntrackedParameter<std::string>("runType", "No run type selected") ;
provinfofolder_ = parameters_.getUntrackedParameter<std::string>("provInfoFolder", "ProvInfo") ;
subsystemname_ = parameters_.getUntrackedParameter<std::string>("subSystemFolder", "Info") ;
globalTag_ = "MODULE::DEFAULT";
runType_ = parameters_.getUntrackedParameter<std::string>("runType", "No run type selected") ;
provinfofolder_ = parameters_.getUntrackedParameter<std::string>("provInfoFolder", "ProvInfo") ;
subsystemname_ = parameters_.getUntrackedParameter<std::string>("subSystemFolder", "Info") ;
L1gt_ = consumes<L1GlobalTriggerReadoutRecord>(parameters_.getUntrackedParameter<std::string>("L1gt","gtDigis"));
L1gtEvm_ = consumes<L1GlobalTriggerEvmReadoutRecord>(parameters_.getUntrackedParameter<std::string>("L1gtEvm","gtEvmDigis"));
dcsStatusCollection_ = consumes<DcsStatusCollection>(parameters_.getUntrackedParameter<std::string>("dcsStatusCollection","scalersRawToDigi"));

// initialize
nameProcess_ = "HLT"; // the process name is not contained in this ps
Expand Down Expand Up @@ -353,7 +356,7 @@ DQMProvInfo::makeDcsInfo(const edm::Event& e)
{

edm::Handle<DcsStatusCollection> dcsStatus;
e.getByLabel("scalersRawToDigi", dcsStatus);
e.getByToken(dcsStatusCollection_, dcsStatus);
for (DcsStatusCollection::const_iterator dcsStatusItr = dcsStatus->begin();
dcsStatusItr != dcsStatus->end(); ++dcsStatusItr)
{
Expand Down Expand Up @@ -422,7 +425,7 @@ DQMProvInfo::makeGtInfo(const edm::Event& e)
{

edm::Handle<L1GlobalTriggerReadoutRecord> gtrr_handle;
e.getByLabel("gtDigis", gtrr_handle);
e.getByToken(L1gt_, gtrr_handle);
L1GlobalTriggerReadoutRecord const* gtrr = gtrr_handle.product();
L1GtFdlWord fdlWord ;
if (gtrr)
Expand All @@ -439,7 +442,7 @@ DQMProvInfo::makeGtInfo(const edm::Event& e)

//
edm::Handle<L1GlobalTriggerEvmReadoutRecord> gtEvm_handle;
e.getByLabel("gtEvmDigis", gtEvm_handle);
e.getByToken(L1gtEvm_, gtEvm_handle);
L1GlobalTriggerEvmReadoutRecord const* gtevm = gtEvm_handle.product();

L1GtfeWord gtfeEvmWord;
Expand Down
8 changes: 8 additions & 0 deletions DQMServices/Components/src/DQMProvInfo.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@
#include <DQMServices/Core/interface/DQMStore.h>
#include <DQMServices/Core/interface/MonitorElement.h>

//DataFormats
#include "DataFormats/Scalers/interface/DcsStatus.h"
#include "DataFormats/L1GlobalTrigger/interface/L1GlobalTriggerReadoutRecord.h"
#include "DataFormats/L1GlobalTrigger/interface/L1GlobalTriggerEvmReadoutRecord.h"

#include <string>
#include <vector>

Expand Down Expand Up @@ -56,6 +61,9 @@ class DQMProvInfo: public edm::EDAnalyzer{
std::string globalTag_;
std::string runType_;
std::string nameProcess_;
edm::EDGetTokenT<L1GlobalTriggerReadoutRecord> L1gt_;
edm::EDGetTokenT<L1GlobalTriggerEvmReadoutRecord> L1gtEvm_;
edm::EDGetTokenT<DcsStatusCollection> dcsStatusCollection_;

bool physDecl_;
bool dcs25[25];
Expand Down

0 comments on commit 8045748

Please sign in to comment.