Merge pull request #38508 from cms-trackeralign/follow-up-toHG-PCL

Follow up to new high granularity pixel alignment for the PCL
cms-sw · Jun 26, 2022 · a898dc1 · a898dc1
2 parents b5a1580 + 2ee0391
commit a898dc1
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 28 deletions.
diff --git a/Alignment/CommonAlignmentProducer/python/AlcaSiPixelAliHarvesterHG_cff.py b/Alignment/CommonAlignmentProducer/python/AlcaSiPixelAliHarvesterHG_cff.py
@@ -41,7 +41,7 @@
     pedeSteerer = dict(
         pedeCommand = 'pede',
         method = 'inversion  5  0.8',
-        options = cms.vstring(
+        options = [
             #'regularisation 1.0 0.05', # non-stated pre-sigma 50 mrad or 500 mum
             'entries 500',
             'chisqcut  30.0  4.5',
@@ -50,9 +50,9 @@
             'skipemptycons' 
             #'outlierdownweighting 3','dwfractioncut 0.1'
             #'outlierdownweighting 5','dwfractioncut 0.2'
-        ),
+        ],
         fileDir = 'HGalignment/',
-        runDir = cms.untracked.string('HGalignment/'),
+        runDir = 'HGalignment/',
         steerFile = 'pedeSteerHG',
         pedeDump = 'pedeHG.dump'
     ),
@@ -71,10 +71,9 @@
 
 from DQMServices.Core.DQMEDHarvester import DQMEDHarvester
 dqmEnvSiPixelAliHG = DQMEDHarvester('DQMHarvestingMetadata',
-                                  subSystemFolder = cms.untracked.string('AlCaReco'),  
-                                  )
+                                    subSystemFolder = cms.untracked.string('AlCaReco'))
 
 ALCAHARVESTSiPixelAliHG = cms.Sequence(SiPixelAliMilleFileExtractorHG*
-                                     SiPixelAliPedeAlignmentProducerHG*
-                                     SiPixelAliDQMModuleHG*
-                                     dqmEnvSiPixelAliHG)
+                                       SiPixelAliPedeAlignmentProducerHG*
+                                       SiPixelAliDQMModuleHG*
+                                       dqmEnvSiPixelAliHG)
diff --git a/Alignment/CommonAlignmentProducer/python/AlignmentProducer_cff.py b/Alignment/CommonAlignmentProducer/python/AlignmentProducer_cff.py
@@ -77,6 +77,9 @@
 
                     # update alignables if triggered by corresponding input IOV boundary
                     enableAlignableUpdates = cms.bool(False),
+
+                    # Change tracker alignment record name to avoid confusion bettwen HG and LG PCL alignment
+                    trackerAlignmentRcdName = cms.string("TrackerAlignmentRcd")
                     )
 
 import Geometry.DTGeometryBuilder.dtGeometryDB_cfi

diff --git a/Alignment/CommonAlignmentProducer/src/AlignmentProducerBase.cc b/Alignment/CommonAlignmentProducer/src/AlignmentProducerBase.cc
@@ -854,14 +854,7 @@ void AlignmentProducerBase::writeForRunRange(cond::Time_t time) {
 
     auto alignments = alignableTracker_->alignments();
     auto alignmentErrors = alignableTracker_->alignmentErrors();
-    this->writeDB(
-        // ~alignments, "TrackerAlignmentRcd", alignmentErrors, "TrackerAlignmentErrorExtendedRcd", trackerGlobal, time);
-        alignments,
-        tkAliRcdName_,
-        alignmentErrors,
-        "TrackerAlignmentErrorExtendedRcd",
-        trackerGlobal,
-        time);
+    this->writeDB(alignments, tkAliRcdName_, alignmentErrors, "TrackerAlignmentErrorExtendedRcd", trackerGlobal, time);
 
     // Save surface deformations to database
     if (saveDeformationsToDB_) {

diff --git a/Alignment/MillePedeAlignmentAlgorithm/plugins/MillePedeAlignmentAlgorithm.cc b/Alignment/MillePedeAlignmentAlgorithm/plugins/MillePedeAlignmentAlgorithm.cc
@@ -181,17 +181,16 @@ void MillePedeAlignmentAlgorithm::initialize(const edm::EventSetup &setup,
   //Retrieve tracker topology from geometry
   const TrackerTopology *const tTopo = &setup.getData(topoToken_);
 
-  //Retrieve tracker geometry
-  const TrackerGeometry *tGeom = &setup.getData(geomToken_);
-
-  //Retrieve PixelTopologyMap
-  pixelTopologyMap = std::make_shared<PixelTopologyMap>(tGeom, tTopo);
-
   //Retrieve the thresolds cuts from DB for the PCL
   if (runAtPCL_) {
     const auto &th = &setup.getData(aliThrToken_);
     theThresholds = std::make_shared<AlignPCLThresholdsHG>();
     storeThresholds(th->getNrecords(), th->getThreshold_Map(), th->getFloatMap());
+
+    //Retrieve tracker geometry
+    const TrackerGeometry *tGeom = &setup.getData(geomToken_);
+    //Retrieve PixelTopologyMap
+    pixelTopologyMap = std::make_shared<PixelTopologyMap>(tGeom, tTopo);
   }
 
   theAlignableNavigator = std::make_unique<AlignableNavigator>(extras, tracker, muon);

diff --git a/CondFormats/PCLConfig/src/AlignPCLThresholdsHG.cc b/CondFormats/PCLConfig/src/AlignPCLThresholdsHG.cc
@@ -101,12 +101,7 @@ float AlignPCLThresholdsHG::getFractionCut(const std::string &AlignableId, const
 //****************************************************************************//
 const bool AlignPCLThresholdsHG::hasFloatMap(const std::string &AlignableId) const {
   const auto &it = floatMap_.find(AlignableId);
-
-  if (it != floatMap_.end()) {
-    return true;
-  } else {
-    return false;
-  }
+  return (it != floatMap_.end());
 }
 
 //****************************************************************************//