Clang check readability-delete-null-pointer

cms-sw · Aug 22, 2017 · adce08f · adce08f
1 parent e739f38
commit adce08f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Geometry/EcalAlgo/src/EcalBarrelGeometry.cc b/Geometry/EcalAlgo/src/EcalBarrelGeometry.cc
@@ -38,7 +38,7 @@ EcalBarrelGeometry::~EcalBarrelGeometry()
   {
     auto ptr = m_borderPtrVec.load(std::memory_order_acquire);
     for(auto& v: (*ptr)) {
-        if(v) delete v;
+        delete v;
         v = nullptr;
     }
     delete m_borderPtrVec.load() ;

diff --git a/Geometry/EcalAlgo/src/EcalEndcapGeometry.cc b/Geometry/EcalAlgo/src/EcalEndcapGeometry.cc
@@ -45,7 +45,7 @@ EcalEndcapGeometry::~EcalEndcapGeometry()
   {
     auto ptr = m_borderPtrVec.load(std::memory_order_acquire);
     for(auto& v: (*ptr)) {
-        if(v) delete v;
+        delete v;
         v = nullptr;
     }
     delete m_borderPtrVec.load() ;