Skip to content

Commit

Permalink
Merge pull request #25374 from arossi83/HITnuningAndCleaning18
Browse files Browse the repository at this point in the history 
Tracker DQM HI Quality Test tuning and cleaning for Offline and Online
  • Loading branch information
@cmsbuild
cmsbuild committed Dec 5, 2018
2 parents fbce024 + 81e9167 commit f8b2f67
Show file tree
Hide file tree
Showing 7 changed files with 172 additions and 72 deletions.
8 changes: 7 additions & 1 deletion DQM/Integration/python/clients/sistrip_dqm_sourceclient-live_cfg.py
View file
Expand Up @@ -552,7 +552,13 @@
process.TrackingAnalyser.verbose = cms.untracked.bool(True)
process.TrackingClient = cms.Sequence( process.TrackingAnalyser )

process.trackingQTester.qtList = cms.untracked.FileInPath('DQM/TrackingMonitorClient/data/tracking_qualitytest_config.xml')
process.stripQTester.qtList = cms.untracked.FileInPath('DQM/SiStripMonitorClient/data/sistrip_qualitytest_config_heavyion.xml')
process.stripQTester.prescaleFactor = cms.untracked.int32(2)
process.stripQTester.getQualityTestsFromFile = cms.untracked.bool(True)
process.stripQTester.qtestOnEndLumi = cms.untracked.bool(True)
process.stripQTester.qtestOnEndRun = cms.untracked.bool(True)

process.trackingQTester.qtList = cms.untracked.FileInPath('DQM/TrackingMonitorClient/data/tracking_qualitytest_config_heavyion.xml')
process.trackingQTester.prescaleFactor = cms.untracked.int32(1)
process.trackingQTester.getQualityTestsFromFile = cms.untracked.bool(True)
process.trackingQTester.qtestOnEndLumi = cms.untracked.bool(True)
Expand Down
4 changes: 4 additions & 0 deletions DQM/SiStripMonitorClient/data/sistrip_qualitytest_config_heavyion.xml
View file
Expand Up @@ -121,6 +121,7 @@
<PARAM name="xmin">0</PARAM>
<PARAM name="xmax">10.0</PARAM>
</QTEST>
<!--
<QTEST name="XrangeWithin:NumberOfTracks" activate="true">
<TYPE>ContentsXRange</TYPE>
<PARAM name="error">0.85</PARAM>
Expand Down Expand Up @@ -149,6 +150,7 @@
<PARAM name="xmin">0</PARAM>
<PARAM name="xmax">100.0</PARAM>
</QTEST>
-->
<LINK name="*nBadChannelStatusBits">
<TestName activate="true">MeanWithinExpectedRange:nBadChannelStatusBits</TestName>
</LINK>
Expand Down Expand Up @@ -182,6 +184,7 @@
<LINK name="*Summary_ClusterStoNCorr__OnTrack__TID__PLUS__wheel__*">
<TestName activate="true">MeanWithinExpectedRange:StoNTID</TestName>
</LINK>
<!--
<LINK name="*TrackParameters/GeneralProperties/NumberOfTracks_HeavyIonTk">
<TestName activate="true">XrangeWithin:NumberOfTracks</TestName>
</LINK>
Expand All @@ -194,4 +197,5 @@
<LINK name="*TrackParameters/GeneralProperties/TrackPt_ImpactPoint_HeavyIonTk">
<TestName activate="true">XrangeWithin:TrackPt</TestName>
</LINK>
-->
</TESTCONFIGURATION>
77 changes: 21 additions & 56 deletions DQM/SiStripMonitorClient/data/sistrip_qualitytest_config_tier0_heavyions.xml
View file
@@ -1,6 +1,7 @@
<TESTSCONFIGURATION>
<QTEST name="MeanWithinExpectedRange:nFEDErrors">
<QTEST name="MeanWithinExpectedRange:nFEDErrors" activate="true">
<TYPE>MeanWithinExpected</TYPE>
<PARAM name="minEntries">0</PARAM>
<PARAM name="error">0.05</PARAM>
<PARAM name="warning">0.3</PARAM>
<PARAM name="mean">1.0</PARAM>
Expand All @@ -10,8 +11,9 @@
<PARAM name="xmin">0.0</PARAM>
<PARAM name="xmax">10.0</PARAM>
</QTEST>
<QTEST name="MeanWithinExpectedRange:nBadChannelStatusBits">
<QTEST name="MeanWithinExpectedRange:nBadChannelStatusBits" activate="true">
<TYPE>MeanWithinExpected</TYPE>
<PARAM name="minEntries">0</PARAM>
<PARAM name="error">0.05</PARAM>
<PARAM name="warning">0.3</PARAM>
<PARAM name="mean">1.0</PARAM>
Expand All @@ -21,8 +23,9 @@
<PARAM name="xmin">0.0</PARAM>
<PARAM name="xmax">380.0</PARAM>
</QTEST>
<QTEST name="MeanWithinExpectedRange:nBadActiveChannelStatusBits">
<QTEST name="MeanWithinExpectedRange:nBadActiveChannelStatusBits" activate="true">
<TYPE>MeanWithinExpected</TYPE>
<PARAM name="minEntries">0</PARAM>
<PARAM name="error">0.05</PARAM>
<PARAM name="warning">0.3</PARAM>
<PARAM name="mean">1.0</PARAM>
Expand All @@ -32,7 +35,7 @@
<PARAM name="xmin">0.0</PARAM>
<PARAM name="xmax">380.0</PARAM>
</QTEST>
<QTEST name="ContentsWithinExpected:TkHistoFedError">
<QTEST name="ContentsWithinExpected:TkHistoFedError" activate="true">
<TYPE>ContentsWithinExpected</TYPE>
<PARAM name="minMean">0.0</PARAM>
<PARAM name="maxMean">0.2</PARAM>
Expand All @@ -46,27 +49,29 @@
</QTEST>
<QTEST name="CompareToMedian:TkHistoNumberOfCluster" activate="true">
<TYPE>CompareToMedian</TYPE>
<PARAM name="minEntries">0</PARAM>
<PARAM name="MinRel">0.1</PARAM>
<PARAM name="MaxRel">5.</PARAM>
<PARAM name="UseEmptyBins">0</PARAM>
<PARAM name="MinAbs">0.</PARAM>
<PARAM name="MinAbs">0.001</PARAM>
<PARAM name="MaxAbs">70.</PARAM>
<PARAM name="error">0.30</PARAM>
<PARAM name="warning">0.70</PARAM>
<PARAM name="StatCut">100</PARAM>
</QTEST>
<QTEST name="CompareToMedian:TkHistoNumberOfDigi" activate="true">
<TYPE>CompareToMedian</TYPE>
<PARAM name="minEntries">0</PARAM>
<PARAM name="MinRel">0.1</PARAM>
<PARAM name="MaxRel">5.</PARAM>
<PARAM name="UseEmptyBins">0</PARAM>
<PARAM name="MinAbs">0.</PARAM>
<PARAM name="MinAbs">0.01</PARAM>
<PARAM name="MaxAbs">180.</PARAM>
<PARAM name="error">0.30</PARAM>
<PARAM name="warning">0.70</PARAM>
<PARAM name="StatCut">200</PARAM>
</QTEST>
<QTEST name="MeanWithinExpectedRange:StoNTIB">
<QTEST name="MeanWithinExpectedRange:StoNTIB" activate="true">
<TYPE>MeanWithinExpected</TYPE>
<PARAM name="error">0.05</PARAM>
<PARAM name="warning">0.3</PARAM>
Expand All @@ -76,9 +81,9 @@
<PARAM name="useRange">1</PARAM>
<PARAM name="minEntries">0</PARAM>
<PARAM name="xmin">15.0</PARAM>
<PARAM name="xmax">100.0</PARAM>
<PARAM name="xmax">80.0</PARAM>
</QTEST>
<QTEST name="MeanWithinExpectedRange:StoNTOB">
<QTEST name="MeanWithinExpectedRange:StoNTOB" activate="true">
<TYPE>MeanWithinExpected</TYPE>
<PARAM name="error">0.05</PARAM>
<PARAM name="warning">0.3</PARAM>
Expand All @@ -88,9 +93,9 @@
<PARAM name="useRange">1</PARAM>
<PARAM name="minEntries">0</PARAM>
<PARAM name="xmin">15.0</PARAM>
<PARAM name="xmax">100.0</PARAM>
<PARAM name="xmax">80.0</PARAM>
</QTEST>
<QTEST name="MeanWithinExpectedRange:StoNTEC">
<QTEST name="MeanWithinExpectedRange:StoNTEC" activate="true">
<TYPE>MeanWithinExpected</TYPE>
<PARAM name="error">0.05</PARAM>
<PARAM name="warning">0.3</PARAM>
Expand All @@ -100,9 +105,9 @@
<PARAM name="useRange">1</PARAM>
<PARAM name="minEntries">0</PARAM>
<PARAM name="xmin">15.0</PARAM>
<PARAM name="xmax">100.0</PARAM>
<PARAM name="xmax">80.0</PARAM>
</QTEST>
<QTEST name="MeanWithinExpectedRange:StoNTID">
<QTEST name="MeanWithinExpectedRange:StoNTID" activate="true">
<TYPE>MeanWithinExpected</TYPE>
<PARAM name="error">0.05</PARAM>
<PARAM name="warning">0.3</PARAM>
Expand All @@ -112,43 +117,15 @@
<PARAM name="useRange">1</PARAM>
<PARAM name="minEntries">0</PARAM>
<PARAM name="xmin">15.0</PARAM>
<PARAM name="xmax">100.0</PARAM>
<PARAM name="xmax">80.0</PARAM>
</QTEST>
<QTEST name="XrangeWithin:0-10.0" activate="true">
<QTEST name="XrangeWithin:0-10.0" activate="false">
<TYPE>ContentsXRange</TYPE>
<PARAM name="error">0.2</PARAM>
<PARAM name="warning">0.4</PARAM>
<PARAM name="xmin">0</PARAM>
<PARAM name="xmax">10.0</PARAM>
</QTEST>
<QTEST name="XrangeWithin:NumberOfTracks" activate="true">
<TYPE>ContentsXRange</TYPE>
<PARAM name="error">0.85</PARAM>
<PARAM name="warning">0.95</PARAM>
<PARAM name="xmin">0.0</PARAM>
<PARAM name="xmax">2000.0</PARAM>
</QTEST>
<QTEST name="XrangeWithin:NumberOfRecHitsPerTrk" activate="true">
<TYPE>ContentsXRange</TYPE>
<PARAM name="error">0.80</PARAM>
<PARAM name="warning">0.90</PARAM>
<PARAM name="xmin">4.0</PARAM>
<PARAM name="xmax">35.0</PARAM>
</QTEST>
<QTEST name="XrangeWithin:Chi2overDoF" activate="true">
<TYPE>ContentsXRange</TYPE>
<PARAM name="error">0.85</PARAM>
<PARAM name="warning">0.95</PARAM>
<PARAM name="xmin">0</PARAM>
<PARAM name="xmax">10.0</PARAM>
</QTEST>
<QTEST name="XrangeWithin:TrackPt" activate="true">
<TYPE>ContentsXRange</TYPE>
<PARAM name="error">0.85</PARAM>
<PARAM name="warning">0.95</PARAM>
<PARAM name="xmin">0</PARAM>
<PARAM name="xmax">100.0</PARAM>
</QTEST>
<LINK name="*nFEDErrors">
<TestName activate="true">MeanWithinExpectedRange:nFEDErrors</TestName>
</LINK>
Expand Down Expand Up @@ -185,16 +162,4 @@
<LINK name="*Summary_ClusterStoNCorr__OnTrack__TID__PLUS__wheel__*">
<TestName activate="true">MeanWithinExpectedRange:StoNTID</TestName>
</LINK>
<LINK name="*TrackParameters/GeneralProperties/NumberOfTracks_HeavyIonTk">
<TestName activate="true">XrangeWithin:NumberOfTracks</TestName>
</LINK>
<LINK name="*TrackParameters/HitProperties/NumberOfRecHitsPerTrack_HeavyIonTk">
<TestName activate="true">XrangeWithin:NumberOfRecHitsPerTrk</TestName>
</LINK>
<LINK name="*TrackParameters/GeneralProperties/Chi2oNDF_HeavyIonTk">
<TestName activate="true">XrangeWithin:Chi2overDoF</TestName>
</LINK>
<LINK name="*TrackParameters/GeneralProperties/TrackPt_ImpactPoint_HeavyIonTk">
<TestName activate="true">XrangeWithin:TrackPt</TestName>
</LINK>
</TESTCONFIGURATION>
</TESTSCONFIGURATION>
5 changes: 5 additions & 0 deletions DQM/SiStripMonitorClient/python/SiStripClientConfig_Tier0_cff.py
View file
Expand Up @@ -37,6 +37,11 @@
getQualityTestsFromFile = cms.untracked.bool(True)
)

from Configuration.Eras.Modifier_pp_on_AA_2018_cff import pp_on_AA_2018
pp_on_AA_2018.toModify(siStripQTester,
qtList = cms.untracked.FileInPath('DQM/SiStripMonitorClient/data/sistrip_qualitytest_config_tier0_heavyions.xml')
)

from CalibTracker.SiStripESProducers.SiStripBadModuleFedErrESSource_cfi import*
siStripBadModuleFedErrESSource.appendToDataLabel = cms.string('BadModules_from_FEDBadChannel')
siStripBadModuleFedErrESSource.ReadFromFile = cms.bool(False)
Expand Down
16 changes: 16 additions & 0 deletions DQM/TrackingMonitorClient/data/tracking_qualitytest_config_heavyion.xml
View file
Expand Up @@ -28,6 +28,20 @@
<PARAM name="xmax">100.0</PARAM>
</QTEST>

<LINK name="*TrackParameters/GeneralProperties/NumberOfTracks_GenTk">
<TestName activate="true">XrangeWithin:NumberOfTracks</TestName>
</LINK>
<LINK name="*TrackParameters/HitProperties/NumberOfRecHitsPerTrack_GenTk">
<TestName activate="true">XrangeWithin:NumberOfRecHitsPerTrk</TestName>
</LINK>
<LINK name="*TrackParameters/GeneralProperties/Chi2oNDF_GenTk">
<TestName activate="true">XrangeWithin:Chi2overDoF</TestName>
</LINK>
<LINK name="*TrackParameters/GeneralProperties/TrackPt_ImpactPoint_GenTk">
<TestName activate="true">XrangeWithin:TrackPt</TestName>
</LINK>

<!--
<LINK name="*TrackParameters/GeneralProperties/NumberOfTracks_HeavyIonTk">
<TestName activate="true">XrangeWithin:NumberOfTracks</TestName>
</LINK>
Expand All @@ -40,4 +54,6 @@
<LINK name="*TrackParameters/GeneralProperties/TrackPt_ImpactPoint_HeavyIonTk">
<TestName activate="true">XrangeWithin:TrackPt</TestName>
</LINK>
-->

</TESTCONFIGURATION>

0 comments on commit f8b2f67

Please sign in to comment.