Better error handling in XrdRequestManager

[Dr15Jones]

A deadlock situation happened in the Tier 0 because an error condition was missed in the implementation of XrdRequestManager. The fix was done in pull request #12590. However, that pull request makes an implicit error condition for m_activeSources.size()==0 rather than any explicit error condition. This makes handling errors difficult to follow in the code.

We should look into better compartmentalization of the different tasks being handled by XrdRequestManager to make the error handling more localized.

[cmsbuild]

A new Issue was created by @Dr15Jones (Chris Jones).

@davidlange6, @smuzaffar, @Degano, @davidlt can you please review it and eventually sign/assign? Thanks.

Following commands in first line of a comment are recognized

• +1|approve[d]|sign[ed]: L1/L2's to approve it
• -1|reject[ed]: L1/L2's to reject it
• assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
• unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
• hold: L1/all L2's/release manager to mark it as on hold
• unhold: L1/user who put this PR on hold
• merge: L1/release managers to merge this request

[Dr15Jones]

assign core

[Dr15Jones]

The hypernews thread for the problem was
https://hypernews.cern.ch/HyperNews/CMS/get/recoDevelopment/1400.html

[Dr15Jones]

assign core

[cmsbuild]

New categories assigned: core

@Dr15Jones,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks

[Dr15Jones]

+1
Solved in #12593

[cmsbuild]

This issue is fully signed and ready to be closed.