Two copies of L1TMuonEndcapParamsRcd.h/cc with different captilizations

[ericvaandering]

The file L1TMuonEndcapParamsRcd.h and corresponding cc file exist in Endcap and EndCap varieties.

I noticed this because when checking out on a Mac, git is not particularly happy with the situation. @Dr15Jones advised me to open an issue on this.

[cmsbuild]

A new Issue was created by @ericvaandering Eric Vaandering.

@davidlange6, @Dr15Jones, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[Dr15Jones]

assign db

[cmsbuild]

New categories assigned: db

@ggovi you have been requested to review this Pull request/Issue and eventually sign? Thanks

[Dr15Jones]

assign alca

[cmsbuild]

New categories assigned: alca

@mmusich,@cerminar,@arunhep,@franzoni,@ghellwig you have been requested to review this Pull request/Issue and eventually sign? Thanks

[Dr15Jones]

assign l1

[cmsbuild]

New categories assigned: l1

@mulhearn,@rekovic you have been requested to review this Pull request/Issue and eventually sign? Thanks

[Dr15Jones]

Having two files in the same directory whose names only differ based on capitalization is against CMS coding policy. [It causes problems when checking out code on macOS plus it is just confusing.]

[ericvaandering]

This is still out there....

[smuzaffar]

@ggovi , @pohsun, @tlampen, @tocheng, @christopheralanwest

The unused L1TMuonEndcapParamsRcd.h file was removed by #23759 but that caused massive failure #23873 . In #23876 we reverted the change. Can you please check if this is still needed? Is it time to remove unused Endcap?

[christopheralanwest]

@smuzaffar The problem in #23873 is that records of type L1TMuonEndcapParamsRcd are present in nearly all data GTs and all 2017 and later MC GTs:

https://cms-conddb.cern.ch/cmsDbBrowser/search/Prod/L1TMuonEndcapParams

It is necessary to have a definition in CMSSW for every record contained in a global tag. Therefore, to avoid crashing these workflows, we would need to remove L1TMuonEndcapParamsRcd from the 36 relevant queues and update autoCond with new GTs for these queues. Once code that defines L1TMuonEndcapParamsRcd is removed, it will no longer be possible to read older GTs that contain payloads of this record type.

[christopheralanwest]

+1

This is resolved by PR #30109.

[ggovi]

+1

[ggovi]

This issue can be closed.

[mulhearn]

4.5 years!

[tvami]

+alca

[tvami]

@rekovic please sign this issue so it can be closed
or @qliphy @perrotta @ericvaandering if you can close it without the L1 signature, please do so