Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use edm::one modules to access PoolDBOutputService #18340

Closed
Dr15Jones opened this issue Apr 12, 2017 · 9 comments · Fixed by #41094
Closed

Use edm::one modules to access PoolDBOutputService #18340

Dr15Jones opened this issue Apr 12, 2017 · 9 comments · Fixed by #41094

Comments

@Dr15Jones
Copy link
Contributor

The PoolDBOutputService appears to be properly thread safe by using a std::mutex. However, since the framework will still schedule multiple modules to run concurrently where those modules would then be fighting over the mutex lock and therefore some of them would stall. If, instead, the modules would be declared edm::one modules and would declare a SharedResource on the PoolDBOutputService, the framework would schedule only one module to talk to the service at a time and could run other modules concurrently which do not need the service.

Such a change is made easier because many of the modules that use the PoolDBOutputService appear to be templated classes: BoostIODBWriter<>, ConditionDBWriter<> and DummyCondDBWriter<>.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 12, 2017

A new Issue was created by @Dr15Jones Chris Jones.

@davidlange6, @Dr15Jones, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

assign alca

@cmsbuild
Copy link
Contributor

New categories assigned: alca

@mmusich,@cerminar,@arunhep,@franzoni,@ghellwig you have been requested to review this Pull request/Issue and eventually sign? Thanks

@tvami
Copy link
Contributor

tvami commented Aug 3, 2021

unassign alca
assign db

  • I think this needs a DB signature, not AlCa

@tvami
Copy link
Contributor

tvami commented Aug 3, 2021

assign db

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2021

New categories assigned: db

@ggovi you have been requested to review this Pull request/Issue and eventually sign? Thanks

@tvami
Copy link
Contributor

tvami commented Mar 18, 2023

With Giacomo leaving CMS, I looked into this issue. I understand of the current status is that most of the work was actually done by @mmusich in #40793 for ConditionDBWriter. I gave a try to resolve the problem in the remaining two files in the PR #41094

@tvami
Copy link
Contributor

tvami commented Mar 20, 2023

+db

@cmsbuild
Copy link
Contributor

This issue is fully signed and ready to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants