-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SiPixelPhase1TrackingParticleV does not clear trackIdToHitPtr_ #21079
Comments
A new Issue was created by @Dr15Jones Chris Jones. @davidlange6, @Dr15Jones, @smuzaffar can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
@slava77 here is the memory problem. |
assign dqm |
New categories assigned: dqm @kmaeshima,@vanbesien,@vazzolini,@dmitrijus you have been requested to review this Pull request/Issue and eventually sign? Thanks |
@Dr15Jones Thanks for spotting the cause of this. Will resolve shortly. |
PR #21084 opened with fix. |
+1 |
This issue is fully signed and ready to be closed. |
Fixed |
@Dr15Jones I note that the current target for the closed PR is CMSSW_10_0_X and that there isn't a 9_4_0 release (only pre-release) yet. Would it be prudent/worth it to open a PR for adding this fix to 9_4_0 (assuming that the plans for using 9_4_0 haven't changed)? |
@davidlange6 would you want a 9_4 backport of #21084 ? It would get rid of some memory hoarding and fix a reproducibility issue. |
SiPixelPhase1TrackingParticleV has the member data
which it fills with PSimHits from the event and then does a lookup later for the hits. The problem is the code never clears the container. This means the container holds stale pointers which were from old events.
The relevant function is:
cmssw/Validation/SiPixelPhase1TrackingParticleV/src/SiPixelPhase1TrackingParticleV.cc
Line 49 in 026420d
The simplest solution would be to remove
trackIdToHitPtr_
as a member data and just have it a local variable of the module.The text was updated successfully, but these errors were encountered: