Pixel Validation - Tracking Particle code fix. #21084
Conversation
…cle pixel validation code would continue to contain stale pointers from old events without being cleared. Solution, removed as a member data and just have it as a local variable.
|
The code-checks are being triggered in jenkins. |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21084/1718 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-21084/1718/git-diff.patch You can run |
| @@ -51,6 +51,7 @@ void SiPixelPhase1TrackingParticleV::analyze(const edm::Event& iEvent, const edm | |||
| edm::Handle<TrackingParticleCollection> TruthTrackContainer; | |||
| iEvent.getByToken( vec_TrackingParticle_Token_, TruthTrackContainer ); | |||
| const TrackingParticleCollection *tPC = TruthTrackContainer.product(); | |||
| std::vector<std::pair<unsigned int, const PSimHit *>> trackIdToHitPtr_; | |||
There was a problem hiding this comment.
Please change name to just trackIdToHitPtr since we reserve a following underscore for member data names.
There was a problem hiding this comment.
Also, be sure to do
curl https://cmssdt.cern.ch/SDT/code-checks/PR-21084/1718/git-diff.patch | patch -p1
to pick up the changes needed to pass the code-checks.
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @davidcarbonis (Alexander Morton) for master. It involves the following packages: Validation/SiPixelPhase1TrackingParticleV @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Resolved a long standing bug where trackIdToHitPtr_ in tracking particle pixel validation code would continue to contain stale pointers from old events without being cleared. Solution, removed as a member data and just have it as a local variable.
Problem cause detailed in issue #21079