New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set dedicated L1 DQM efficiency sequences according to PD #21963
Comments
A new Issue was created by @fabiocos Fabio Cossutti. @davidlange6, @Dr15Jones, @smuzaffar, @fabiocos can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
Yes this is correct. For the T0 configuration For the RelVal steps configuration I need to go through the file and look for which workflows the two sequences need to run. |
@thomreis can we finalize this move by this week? Otherwise better to temporarily reintegrate the old sequence definition in L1TMon, until this is not done |
@fabiocos yes, I will work on it this week. |
@thomreis do you have a suggestion for relvals? it would be good to have this setup before 10_1_0_pre1 |
Hi @fabiocos I am running some matrix tests at the moment to see if my changes to relval_steps.py have the desired effect. |
assign dqm |
New categories assigned: dqm @kmaeshima,@vanbesien,@jfernan2,@vazzolini,@dmitrijus you have been requested to review this Pull request/Issue and eventually sign? Thanks |
assign pdmv |
New categories assigned: pdmv @fabozzi,@prebello,@GurpreetSinghChahal you have been requested to review this Pull request/Issue and eventually sign? Thanks |
Changes for RelVal configuration in PR #22160 |
The change in PR #21754 implies that efficiencies are computed by dedicated sequences for electrons and tau/muons. RelVals need to be adapted accordingly.
@thomreis @dmitrijus Could you please provide the suggested modification to
https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/relval_steps.py
to add explicitly the electron and muon sequences where needed?
A similar customisation should be propagated to the T0 configuration
The text was updated successfully, but these errors were encountered: