Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set dedicated L1 DQM efficiency sequences according to PD #21963

Closed
fabiocos opened this issue Jan 25, 2018 · 12 comments
Closed

Set dedicated L1 DQM efficiency sequences according to PD #21963

fabiocos opened this issue Jan 25, 2018 · 12 comments

Comments

@fabiocos
Copy link
Contributor

The change in PR #21754 implies that efficiencies are computed by dedicated sequences for electrons and tau/muons. RelVals need to be adapted accordingly.

@thomreis @dmitrijus Could you please provide the suggested modification to

https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/relval_steps.py

to add explicitly the electron and muon sequences where needed?

A similar customisation should be propagated to the T0 configuration

@cmsbuild
Copy link
Contributor

A new Issue was created by @fabiocos Fabio Cossutti.

@davidlange6, @Dr15Jones, @smuzaffar, @fabiocos can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@thomreis
Copy link
Contributor

thomreis commented Jan 25, 2018

Yes this is correct.

For the T0 configuration @L1TEgamma should be added to the SingleElectron configuration here https://github.com/dmwm/T0/blob/master/etc/ProdOfflineConfiguration.py#L571
@L1TMuon should be added to the SingleMuon configuration here https://github.com/dmwm/T0/blob/master/etc/ProdOfflineConfiguration.py#L586
These are the 2017 datasets but I assume there will be a corresponding configuration for the 2018 datasets.
I did not see a special customisation for the express stream but the two sequences could also run there.

For the RelVal steps configuration I need to go through the file and look for which workflows the two sequences need to run.

@fabiocos
Copy link
Contributor Author

@thomreis can we finalize this move by this week? Otherwise better to temporarily reintegrate the old sequence definition in L1TMon, until this is not done

@thomreis
Copy link
Contributor

@fabiocos yes, I will work on it this week.
Shall I make a PR for the dmwm/T0 myself or who is responsible for the autoDQM file there?

@fabiocos
Copy link
Contributor Author

fabiocos commented Feb 5, 2018

@thomreis do you have a suggestion for relvals? it would be good to have this setup before 10_1_0_pre1

@thomreis
Copy link
Contributor

thomreis commented Feb 5, 2018

Hi @fabiocos I am running some matrix tests at the moment to see if my changes to relval_steps.py have the desired effect.
I had in mind to run for RECODR2_2016 and RECODR2_2017 steps with the corresponding harvesting steps HARVESTDR2 and HARVEST2017. This would mean that the modules are running on more datasets than needed but apart from the skims there is no distinction between datasets for the DQM and harvesting step.

@dmitrijus
Copy link
Contributor

assign dqm

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2018

New categories assigned: dqm

@kmaeshima,@vanbesien,@jfernan2,@vazzolini,@dmitrijus you have been requested to review this Pull request/Issue and eventually sign? Thanks

@dmitrijus
Copy link
Contributor

assign pdmv

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2018

New categories assigned: pdmv

@fabozzi,@prebello,@GurpreetSinghChahal you have been requested to review this Pull request/Issue and eventually sign? Thanks

@thomreis
Copy link
Contributor

thomreis commented Feb 8, 2018

Changes for RelVal configuration in PR #22160

@fabiocos
Copy link
Contributor Author

@thomreis @fabozzi @prebello The PR with the update of the L1 sequences has been merged, I expect to see in the validation of 10_1_0_pre2 a confirmation that the new functionality is now fully working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants