Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt RelVal steps and standard RelVal for L1T offline DQM sequences #22160

Merged
merged 4 commits into from Feb 12, 2018

Conversation

thomreis
Copy link
Contributor

@thomreis thomreis commented Feb 8, 2018

The L1TEgamma and L1TMuon offline DQM sequences should only run on SingleElectron and SingleMuon datasets, respectively. For other datasets the resulting efficiency plots do not give useful information and instead confuse shfiters and validators.

This PR changes the RelVal steps and workflow configurations to run the L1T efficiency DQM modules only for some datasets and MC samples.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2018

A new Pull Request was created by @thomreis (Thomas Reis) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@cmsbuild, @GurpreetSinghChahal, @prebello, @kpedro88, @fabozzi can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @ebrondol, @ghellwig, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@thomreis
Copy link
Contributor Author

thomreis commented Feb 8, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25977/console Started: 2018/02/08 15:05

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2018

Comparison job queued.

@fabozzi
Copy link
Contributor

fabozzi commented Feb 8, 2018

Hi, do you really want to add these sequences also to 2016 MC relvals? We do not produce these relvals in validation campaigns

@thomreis
Copy link
Contributor Author

thomreis commented Feb 8, 2018

Hi,
which ones are those? 1330.0 is running in the standard tests for new PRs for example.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22160/25977/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22160/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017+HARVESTNANOAODMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2307753
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2307592
  • DQMHistoTests: Total skipped: 160
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.479999999996 KiB( 21 files compared)
  • Checked 107 log files, 9 edm output root files, 27 DQM output files

@fabozzi
Copy link
Contributor

fabozzi commented Feb 10, 2018

+1

@fabiocos
Copy link
Contributor

please test workflow 25200,25206

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 10, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26006/console Started: 2018/02/10 17:01

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22160/26006/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22160/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017+HARVESTNANOAODMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2307753
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2307592
  • DQMHistoTests: Total skipped: 160
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.14999999991 KiB( 21 files compared)
  • Checked 107 log files, 9 edm output root files, 27 DQM output files

@fabiocos
Copy link
Contributor

@kpedro88 could you please check this update of the relval definition?

@kpedro88
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3b64fed into cms-sw:master Feb 12, 2018
@thomreis thomreis deleted the l1tdqm_relvalconf_changes branch March 27, 2018 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants