[CodeFormat] CMS clang-format customization not applied

[smuzaffar]

Thanks to @wddgit ( #26678 (review) ) , I noticed that CMS clang-format customization (via https://github.com/cms-sw/cmssw/blob/master/.clang-format ) were not applied in the automatic PRs [a] made by @cmsbuild. This effect packages in dqm, l1, alca, simulation categories.

Note that PRs which are already merged did not break functionality, it was just that CMS clang-format customization were not applied.

code-format build rule has been fixed and will be part of next 10.6.X IB. We will run clang-format for these merged PRs to get this code correctly fixed.

I am really sorry for the time you have wasted reviewing these PRs.

[a]

• Running code-format for dqm #26619
• Running code-format for simulation #26621
• Running code-format for simulation #26623
• Running code-format for simulation #26624
• Running code-format for alca #26626
• Running code-format for dqm #26627
• Running code-format for dqm #26628
• Running code-format for l1 #26629
• Running code-format for alca #26630
• Running code-format for dqm #26631
• Running code-format for simulation #26632

[smuzaffar]

assign dqm, l1, alca, simulation

[cmsbuild]

New categories assigned: dqm,alca,simulation,l1

@mdhildreth,@jfernan2,@christopheralanwest,@franzoni,@andrius-k,@schneiml,@fioriNTU,@tlampen,@pohsun,@rekovic,@tocheng,@kmaeshima,@civanch you have been requested to review this Pull request/Issue and eventually sign? Thanks

[cmsbuild]

A new Issue was created by @smuzaffar Malik Shahzad Muzaffar.

@davidlange6, @Dr15Jones, @smuzaffar, @fabiocos, @kpedro88 can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[fabiocos]

@smuzaffar is this just affecting the indentation in namespaces?

[smuzaffar]

@fabiocos , yes mostly but it also fixes few things e.g.

• line length: instead of default 80 to cms setting 120 e.g. https://github.com/cms-sw/cmssw/pull/26690/files#diff-9ce9a7fb6cc798736e0af0363bce6fd0R29
• Constructor initializers: https://github.com/cms-sw/cmssw/pull/26690/files#diff-9ce9a7fb6cc798736e0af0363bce6fd0R20

Please see #26690 which properly applied CMS clang-format customizations.

[smuzaffar]

closing this as all PRs to fix this formating are now merged in cmssw.