Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular dependency in SimG4Core between Application and GFlash #27451

Closed
Dr15Jones opened this issue Jul 6, 2019 · 8 comments
Closed

Circular dependency in SimG4Core between Application and GFlash #27451

Dr15Jones opened this issue Jul 6, 2019 · 8 comments

Comments

@Dr15Jones
Copy link
Contributor

SimG4Core/Application links with SimG4Core/GFlash while within G4Flash we have these includes

src/GflashEMShowerModel.cc:#include "SimG4Core/Application/interface/SteppingAction.h"
src/GflashHadronShowerModel.cc:#include "SimG4Core/Application/interface/SteppingAction.h"

In order for UBSAN to work, SimG4Core/GFlash needs to link with the library that has the definition of SteppingAction (in order to get the type info).

@Dr15Jones
Copy link
Contributor Author

assign simulation

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2019

New categories assigned: simulation

@mdhildreth,@civanch you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2019

A new Issue was created by @Dr15Jones Chris Jones.

@davidlange6, @Dr15Jones, @smuzaffar, @fabiocos, @kpedro88 can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@civanch
Copy link
Contributor

civanch commented Jul 6, 2019

@Dr15Jones , thanks, I recently also see this and want to fix asap.

@civanch
Copy link
Contributor

civanch commented Jul 7, 2019

Fixed in #27452

@Dr15Jones
Copy link
Contributor Author

@civanch please sign this issue as the problem has been fixed.

@civanch
Copy link
Contributor

civanch commented Jul 13, 2019

+1

@cmsbuild
Copy link
Contributor

This issue is fully signed and ready to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants