New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is HardEventHypothesis class still useful? #29834
Comments
A new Issue was created by @makortel Matti Kortelainen. @Dr15Jones, @silviodonato, @dpiparo, @smuzaffar, @makortel can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
assign reconstruction, analysis |
At a first glance it could even safely get removed |
Thanks @perrotta, I will then remove the |
+1 |
Done as part of #29840. |
Wow, this is 12+ years old, I entirely forgot about it. It has no purpose anymore and can be removed. |
Thanks for the confirmation @rappoccio. |
Created PR #29903 to remove the HardEventHypothesis class from CMSSW |
+1
|
This issue is fully signed and ready to be closed. |
Thanks! |
While trying to address #29306 and #26618 I came across
mkevhyp
andcmssw/DataFormats/PatCandidates/interface/HardEventHypothesis.h
Line 110 in e1b8483
class.
git grep HardEventHypothesis
does not show any use in CMSSW beyond the class definition and the Skeletons template. TheHardEventHypothesis.h
looks like it has not gone throughclang-format
. Git history shows total of 4 commits, last one from 2013 for removing CVS keywords, and the other 3 from 2008.Before putting effort into modernizing the template I would like to understand if this class is still useful. If not, I would really like to remove it, or at least the Skeletons template.
The text was updated successfully, but these errors were encountered: