New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and modernize Skeleton template scripts #29840
Conversation
They are not needed anymore
The code-checks are being triggered in jenkins. |
@wddgit @Dr15Jones Could you take a quick look, please? |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29840/15380
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29840/15385
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: FWCore/Skeletons @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR enables the
mk*
skeleton generation scripts to run again by moving themkTemplates
directory (of the templates) fromFWCore/Skeletons/scripts/mkTemplates
toFWCore/Skeletons/mkTemplates
. Resolves #29306 .Furthermore, this PR modernizes the skeleton templates by accounting the code formatting as much as feasible (some empty lines turned out to be difficult to avoid without touching the generation code itself), and by modernizing the code overall (range-for, consumes,
=delete
) following suggestions in #26618.The EventHypothesis template and
mkevhyp
script are removed as obsolete as agreed in #29834.PR validation:
The scripts run (except for
mktmpl
, which appears to be broken already in 10_2_X).