Upper bin edge included when evaluating JEC when using non-linear lookup

[kirschen]

Discovered an inconsistency between the current non-linear lookup of bin indices and both

1. the previous "legacy" linear index search JetCorrectorParameters::binIndex()
2. the correctionlib implementation for interpreting the JSON files

It seems like this boils down to including the upper bin edge in the non-linear search

cmssw/CondFormats/JetMETObjects/src/JetCorrectorParametersHelper.cc

Line 135 in a59283f

if (value < min || value > max)

vs. excluding it in the linear search and correctionlib

cmssw/CondFormats/JetMETObjects/src/JetCorrectorParameters.cc

Line 190 in a59283f

if (fX[j] >= record(i).xMin(j) && fX[j] < record(i).xMax(j))

@aperloff : Can you confirm? Will put in a tiny PR fixing the inclusion of the upper bin edge it but would be good to get your confirmation.

[cmsbuild]

A new Issue was created by @kirschen Henning Kirschenmann.

@Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[kirschen]

And just for reference: This really only affects the outermost upper bin edge (e.g. for eta-binned corrections usually eta=5.191), so just a nuance, but better to fix if it's easily fixable (which it is).
FYI: @juska @tankit @camclean @lathomas @nsmith-

[makortel]

assign db

FYI @cms-sw/reconstruction-l2 (not sure who else should be made aware)

[cmsbuild]

New categories assigned: db

@ggovi you have been requested to review this Pull request/Issue and eventually sign? Thanks

[ggovi]

addressed by #34382 ?

[perrotta]

@kirschen please confirm that the issue is solved by #34382, and close this github issue if so

[kirschen]

Indeed solved by #34382. Closing...