Fix uppermost bin edge handling in non-linear lookup of JEC bins

[kirschen]

PR description:

Addresses the issue raised in
#34381

Expected change:
only affects the uppermost bin edge (e.g. often 5.191 in eta-binned JEC), now excluding it from the evaluation instead of including it. Should restore the previous behavior of the linear look-up and aligns with the correctionlib lookup used in
https://github.com/cms-jet/JECDatabase/tree/master/scripts/JEC2JSON

PR validation:

Ran local tests on consistency between new "JSON corrections" and cmssw. Now get full consistency over a scan of input parameters including bin-boundaries, out-of-range, etc. cases.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34382/23770

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @kirschen (Henning Kirschenmann) for master.

It involves the following packages:

CondFormats/JetMETObjects

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@rappoccio, @ahinzmann, @mmarionncern, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @clelange, @schoef, @mmusich, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c67dc9/16731/summary.html
COMMIT: 05df768
CMSSW: CMSSW_12_0_X_2021-07-12-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34382/16731/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2787742
• DQMHistoTests: Total failures: 887
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2786854
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1