Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Degridifying unpacked phi to break degeneracies in angular separations for packed candidates: 74X #10008

Merged

Conversation

ferencek
Copy link
Contributor

@ferencek ferencek commented Jul 1, 2015

Backport of #9554

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2015

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_4_X.

Degridifying unpacked phi to break degeneracies in angular separations for packed candidates: 74X

It involves the following packages:

DataFormats/PatCandidates

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@monttj
Copy link
Contributor

monttj commented Jul 6, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2015

@monttj
Copy link
Contributor

monttj commented Jul 7, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Aug 1, 2015
…MSSW_7_4_4

Degridifying unpacked phi to break degeneracies in angular separations for packed candidates: 74X
@cmsbuild cmsbuild merged commit aabe8e3 into cms-sw:CMSSW_7_4_X Aug 1, 2015
@ferencek ferencek deleted the DegridifiedUnpackedPhi_from-CMSSW_7_4_4 branch August 1, 2015 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants