Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new rechit containers #10018

Merged
merged 22 commits into from Jul 8, 2015
Merged

new rechit containers #10018

merged 22 commits into from Jul 8, 2015

Conversation

lveldere
Copy link
Contributor

@lveldere lveldere commented Jul 2, 2015

this pr replaces #9855

  • BaseTrackerRecHit
    BaseTrackerRecHit::initialise qualWord_ in all constructors
  • SiTrackerGS*RecHit
    • preparation for arbitrary hit combinations in fast tracking emulation
    • Note: these containers are FastSim-only
  • FastSimulation/EgammaElectronAlgos/
    • removed outdated obsolete modules
  • TrajectorySeedProducer & TrackCandidateProducer
    • next step towards arbitrary hit combinations
  • SiTrackerGaussianSmearingRecHitConverter
    • adapt to updated recHitContainer
  • Miscelaneous
    • several other classes needed to be migrated to the updated recHitConainer

Lukas and others added 22 commits July 2, 2015 15:25
first version of cleaned up fastsim rechits
982da98 
more mess

more mess
resolve a last compilation error
3a1a44a
make hits aware of the hit combination they reside in, and of the mul…
9e5e638 
…tiple simtracks they may originate from
new typedefs
cf6235a
remove consteness of class SiTrackerGSMatchedRecHit2D members tempora…
acb4082 
…ry to get things compiled
remove outdated analyzer
0b16707
get FastSimulation Tracking and TrackingRecHitProducer to compile
2ad98ae
get FastSimulation/Muon to compile
7c977fc
get FastSimulation/EgammaElectronAlgos to compile, remove dead package
de34e0f
get SLHCUpgrade package to compile again
5c41dd0
correct label
62b9ef7
remove obsolete includes of no-longer-existing header file
59c528b
avoid unnecessary data format version number
f0dc20f
remove unnecessary printouts
ffb6d33
add script to conveniently run harvesting of track validation plots
f1aecbf
@lveldere
Update harvestTrackValidationPlots.py
b403ba3
@lveldere
use subprocess.call() w/o shell=True, fix preamble
2b1060c
@lveldere
clarified error message
d6de9c6
move variables and function common to SiTrackerGSMatched and SiTracke…
0e4f226 
…rGSRecHit to base class, make SiTrackerGS* objects self-aware, correct initialisation of SiTrackerGSRecHits, fix sharesInput function
fix fastsim rechit event id, adapt TrackerHitAssociator to edited fas…
931e5b1 
…tsim rechit format
restore history of class versions
7fe1ea6
harvestTrackValidationPlots.py does not belong to this pr
fdf4def
@lveldere lveldere mentioned this pull request Jul 2, 2015
Closed
@lveldere
Copy link
Contributor Author

lveldere commented Jul 2, 2015

please test

@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Jul 2, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2015

The tests are being triggered in jenkins.

@civanch
Copy link
Contributor

civanch commented Jul 8, 2015

+1

@makortel
Copy link
Contributor

makortel commented Jul 8, 2015

@lveldere Duplicate rate is defined as

tracks associated to a TrackingParticle that is associated to >= 2 tracks
-------------------------------------------------------------------------
                                all tracks

davidlange6 added a commit that referenced this pull request Jul 8, 2015
@davidlange6
Merge pull request #10018 from lveldere/newRecHitContainers_July2
157a804 
new rechit containers
@davidlange6 davidlange6 merged commit 157a804 into cms-sw:CMSSW_7_6_X Jul 8, 2015
@lveldere lveldere deleted the newRecHitContainers_July2 branch July 13, 2015 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-pending comparison-pending fastsim-approved orp-pending pending-signatures reconstruction-approved simulation-approved tests-approved
Projects
None yet
Milestone
CMSSW_7_6_X
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@lveldere @cmsbuild @cvuosalo @slava77 @civanch @makortel @davidlange6