Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HcalCalIsoTrk AlCaReco in the correct RelVal steps #10024

Merged
merged 3 commits into from Jul 19, 2015

Conversation

diguida
Copy link
Contributor

@diguida diguida commented Jul 2, 2015

HcalCalIsoTrk AlCaReco requires L1T information (L1SingleJet68 seed) to select events. This product is not available in RECO, but only in RAW data tier.

With this PR, the AlCaReco is run in the reco sequence, so that the collection is available in the input file.

As a side note, the RelVal were not failing because the HLT menu in use either did not contain HLT_IsoTrk* paths, or no events passed that selection. As a consequence, the trigger bit filter was exiting without any events.

@diguida
Copy link
Contributor Author

diguida commented Jul 2, 2015

@mmusich @bsunanda this is something you want to watch as well.

@mmusich
Copy link
Contributor

mmusich commented Jul 2, 2015

@diguida thanks! I think we should take care also of the other HCAL AlCa producer never tested in RelVals, after changing the eventSetupPathKey.

@diguida
Copy link
Contributor Author

diguida commented Jul 2, 2015

@mmusich you are reading into my mind.
Please expect news about the following producers:
HcalCalNoise, HcalCalGammaJet, HcalCalDijets.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2015

A new Pull Request was created by @diguida (Salvatore Di Guida) for CMSSW_7_6_X.

Add HcalCalIsoTrk AlCaReco in the correct RelVal steps

It involves the following packages:

Configuration/PyReleaseValidation

@cmsbuild, @srimanob, @boudoul, @franzoni can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@diguida
Copy link
Contributor Author

diguida commented Jul 2, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2015

The tests are being triggered in jenkins.

@diguida
Copy link
Contributor Author

diguida commented Jul 3, 2015

@cmsbuild are you still there?

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2015

-1
Tested at: 0efe067
When I ran the RelVals I found an error in the following worklfows:
25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+MINIAODMCUP15/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+MINIAODMCUP15.log
----- Begin Fatal Exception 03-Jul-2015 19:03:54 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
RootEmbeddedFileSequence no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

50202.0 step2

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50+MINIAODMCUP1550/step2_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50+MINIAODMCUP1550.log
----- Begin Fatal Exception 03-Jul-2015 19:08:35 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
RootEmbeddedFileSequence no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10024/5915/summary.html

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@mmusich
Copy link
Contributor

mmusich commented Jul 15, 2015

@franzoni this should help us spotting issues with the HCalIsoTrk producer in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants