Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GenParticlePruner: Bugfix for infinite mother/daughter loops #10028

Conversation

ferencek
Copy link
Contributor

@ferencek ferencek commented Jul 3, 2015

This PR fixes a bug introduced by #9709 where correct handling of infinite mother/daughter loops got broken. The two Sherpa workflows reported to fail in #9709 (comment) now run successfully

[ferencek@lxplus0002 src]$ runTheMatrix.py -l 533.0,534.0 
processing relval_standard
processing relval_highstats
processing relval_pileup
processing relval_generator
processing relval_extendedgen
processing relval_production
processing relval_ged
ignoring relval_upgrade from default matrix
ignoring relval_identity from default matrix
processing relval_machine
processing relval_unsch
processing relval_premix
Running in 4 thread(s)

Preparing to run 533.0 sherpa_ZtoEE_0j_BlackHat_13TeV_MASTER+sherpa_ZtoEE_0j_BlackHat_13TeV_MASTER+HARVESTGEN
cleaning up  533.0_sherpa_ZtoEE_0j_BlackHat_13TeV_MASTER+sherpa_ZtoEE_0j_BlackHat_13TeV_MASTER+HARVESTGEN  in  /afs/cern.ch/work/f/ferencek/GitSandBox/CMSSW_7_5_X_2015-07-02-1100/src

# in: /afs/cern.ch/work/f/ferencek/GitSandBox/CMSSW_7_5_X_2015-07-02-1100/src going to execute cd 533.0_sherpa_ZtoEE_0j_BlackHat_13TeV_MASTER+sherpa_ZtoEE_0j_BlackHat_13TeV_MASTER+HARVESTGEN
 cmsDriver.py sherpa_ZtoEE_0j_BlackHat_13TeV_MASTER_cff  --conditions auto:run2_mc_FULL -s GEN,VALIDATION:genvalid_all --datatier GEN,DQMIO --beamspot Realistic8TeVCollision -n 10 --relval 250000,20000 --eventcontent RAWSIM,DQM --fileout file:step1.root  > step1_sherpa_ZtoEE_0j_BlackHat_13TeV_MASTER+sherpa_ZtoEE_0j_BlackHat_13TeV_MASTER+HARVESTGEN.log  2>&1


Preparing to run 534.0 sherpa_ZtoEE_0j_OpenLoops_13TeV_MASTER+sherpa_ZtoEE_0j_OpenLoops_13TeV_MASTER+HARVESTGEN
cleaning up  534.0_sherpa_ZtoEE_0j_OpenLoops_13TeV_MASTER+sherpa_ZtoEE_0j_OpenLoops_13TeV_MASTER+HARVESTGEN  in  /afs/cern.ch/work/f/ferencek/GitSandBox/CMSSW_7_5_X_2015-07-02-1100/src

# in: /afs/cern.ch/work/f/ferencek/GitSandBox/CMSSW_7_5_X_2015-07-02-1100/src going to execute cd 534.0_sherpa_ZtoEE_0j_OpenLoops_13TeV_MASTER+sherpa_ZtoEE_0j_OpenLoops_13TeV_MASTER+HARVESTGEN
 cmsDriver.py sherpa_ZtoEE_0j_OpenLoops_13TeV_MASTER_cff  --conditions auto:run2_mc_FULL -s GEN,VALIDATION:genvalid_all --datatier GEN,DQMIO --beamspot Realistic8TeVCollision -n 10 --relval 250000,20000 --eventcontent RAWSIM,DQM --fileout file:step1.root  > step1_sherpa_ZtoEE_0j_OpenLoops_13TeV_MASTER+sherpa_ZtoEE_0j_OpenLoops_13TeV_MASTER+HARVESTGEN.log  2>&1


# in: /afs/cern.ch/work/f/ferencek/GitSandBox/CMSSW_7_5_X_2015-07-02-1100/src going to execute cd 533.0_sherpa_ZtoEE_0j_BlackHat_13TeV_MASTER+sherpa_ZtoEE_0j_BlackHat_13TeV_MASTER+HARVESTGEN
 cmsDriver.py step2  --conditions auto:run2_mc_FULL --filein file:step1_inDQM.root -s HARVESTING:genHarvesting --harvesting AtJobEnd --filetype DQM --customise SLHCUpgradeSimulations/Configuration/postLS1Customs.customisePostLS1 --mc  -n 100  --fileout file:step2.root  > step2_sherpa_ZtoEE_0j_BlackHat_13TeV_MASTER+sherpa_ZtoEE_0j_BlackHat_13TeV_MASTER+HARVESTGEN.log  2>&1


# in: /afs/cern.ch/work/f/ferencek/GitSandBox/CMSSW_7_5_X_2015-07-02-1100/src going to execute cd 534.0_sherpa_ZtoEE_0j_OpenLoops_13TeV_MASTER+sherpa_ZtoEE_0j_OpenLoops_13TeV_MASTER+HARVESTGEN
 cmsDriver.py step2  --conditions auto:run2_mc_FULL --filein file:step1_inDQM.root -s HARVESTING:genHarvesting --harvesting AtJobEnd --filetype DQM --customise SLHCUpgradeSimulations/Configuration/postLS1Customs.customisePostLS1 --mc  -n 100  --fileout file:step2.root  > step2_sherpa_ZtoEE_0j_OpenLoops_13TeV_MASTER+sherpa_ZtoEE_0j_OpenLoops_13TeV_MASTER+HARVESTGEN.log  2>&1

533.0_sherpa_ZtoEE_0j_BlackHat_13TeV_MASTER+sherpa_ZtoEE_0j_BlackHat_13TeV_MASTER+HARVESTGEN Step0-PASSED Step1-PASSED  - time date Fri Jul  3 02:46:49 2015-date Fri Jul  3 02:45:53 2015; exit: 0 0
534.0_sherpa_ZtoEE_0j_OpenLoops_13TeV_MASTER+sherpa_ZtoEE_0j_OpenLoops_13TeV_MASTER+HARVESTGEN Step0-PASSED Step1-PASSED  - time date Fri Jul  3 02:46:49 2015-date Fri Jul  3 02:45:56 2015; exit: 0 0
2 2 tests passed, 0 0 failed

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2015

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_5_X.

GenParticlePruner: Bugfix for infinite mother/daughter loops

It involves the following packages:

PhysicsTools/HepMCCandAlgos

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@davidlange6
Copy link
Contributor

All - I will merge this as its causing problems in the IB without this fix- please test and sign off in the meanwhile.

davidlange6 added a commit that referenced this pull request Jul 6, 2015
…psFix_from-CMSSW_7_5_X_2015-07-02-1100

GenParticlePruner: Bugfix for infinite mother/daughter loops
@davidlange6 davidlange6 merged commit 6fab1b8 into cms-sw:CMSSW_7_5_X Jul 6, 2015
@ferencek ferencek deleted the GenParticlePruner-InfiniteLoopsFix_from-CMSSW_7_5_X_2015-07-02-1100 branch July 9, 2015 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants