Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lumi-offset from HF LUTs #10032

Merged
merged 1 commit into from Sep 25, 2015

Conversation

akhukhun
Copy link
Contributor

@akhukhun akhukhun commented Jul 3, 2015

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2015

A new Pull Request was created by @akhukhun for CMSSW_7_6_X.

Remove lumi-offset from HF LUTs

It involves the following packages:

CalibCalorimetry/HcalTPGAlgos

@cmsbuild, @mmusich, @diguida, @mulhearn, @cerminar can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mmusich
Copy link
Contributor

mmusich commented Jul 15, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@mulhearn
Copy link
Contributor

+1

@davidlange6
Copy link
Contributor

+1

@abdoulline
Copy link

@mmusich: may we have it finally approved (& merged) ?

@mmusich
Copy link
Contributor

mmusich commented Sep 25, 2015

+1

@mmusich
Copy link
Contributor

mmusich commented Sep 25, 2015

@abdoulline even if it was ORP approved seems not to have been merged. Sorry if my pending signature delayed

cmsbuild added a commit that referenced this pull request Sep 25, 2015
@cmsbuild cmsbuild merged commit 4c1b93e into cms-sw:CMSSW_7_6_X Sep 25, 2015
@akhukhun akhukhun deleted the remove-lumi-offset branch February 22, 2018 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants