Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve plots in local processing (no change for DQM) #1004

Merged
merged 1 commit into from Oct 16, 2013

Conversation

namapane
Copy link
Contributor

@namapane namapane commented Oct 6, 2013

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2013

A new Pull Request was created by @namapane (Nicola Amapane) for CMSSW_7_0_X.

Improve plots in local processing (no change for DQM)

It involves the following packages:

Validation/DTRecHits

@smuzaffar, @nclopezo, @danduggan, @rovere, @deguio, @eliasron can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@nclopezo
Copy link
Contributor

nclopezo commented Oct 7, 2013

@eliasron
Copy link

eliasron commented Oct 7, 2013

Dear Nicola,

there is currently a campaign to try to move the declaration of histograms away from the constructors to the beginRun process. This would avoid having large spikes in memory consumption at the end of the run. Do you think you could have a look and move them? Thanks.

@cmsbuild
Copy link
Contributor

The following categories have been signed by eron (a.k.a. @eliasron on GitHub): DQM

@cms-git-dqm

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@namapane
Copy link
Contributor Author

Hi,

On 07-Oct-13 14:52, eliasron wrote:

Dear Nicola,

there is currently a campaign to try to move the declaration of
histograms away from the constructors to the beginRun process.

OK, but I supppose you mean to the beginJob, rather than beginRun?

Cheers,
Nicola

This
would avoid having large spikes in memory consumption at the end of the
run. Do you think you could have a look and move them? Thanks.


Reply to this email directly or view it on GitHub
#1004 (comment).

@deguio
Copy link
Contributor

deguio commented Oct 11, 2013

it is beginRun. elias is correct.
everything has been discussed back in June. see the details in:
https://indico.cern.ch/getFile.py/access?contribId=3&resId=0&materialId=slides&confId=256775

ktf added a commit that referenced this pull request Oct 16, 2013
Validation updates -- Improve plots in local processing (no change for DQM)
@ktf ktf merged commit ae8e65f into cms-sw:CMSSW_7_0_X Oct 16, 2013
@namapane namapane deleted the DTRecHitValidationUpdate branch March 17, 2014 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants