Removal of redundant (generic) QIE shape and its usage

[abdoulline]

HCAL QIE shape is described by HcalQieShape
CondFormats/HcalObjects/interface/HcalQIEShape.h

Removed stuff : QieShape + HcalChannelCoder

• is an old redundat/unused (since long time)

[cmsbuild]

A new Pull Request was created by @abdoulline for CMSSW_7_6_X.

Removal of redundant (generic) QIE shape and it's usage

It involves the following packages:

CalibFormats/HcalObjects

@cmsbuild, @mmusich, @diguida, @cerminar can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[mmusich]

please test

[cmsbuild]

The tests are being triggered in jenkins.

[abdoulline]

Looks like the test needs to be re-started ?

[mmusich]

@Degano can you please restart the tests?

[smuzaffar]

tests restarted in jenkins but will take a while to finish as many of the build resources are being used to build 11h00 IBs

[cmsbuild]

+1
Tested at: a04e599
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10042/5991/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10042/5991/summary.html

[diguida]

+1
removing HcalChannelCoder and QieShape classes from release (not consumed anywhere, see here):

• HcalChannelCoder is not used at all;
• QieShape is it a duplicate of HcalQIEShape defined as condition entity class.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[cmsbuild]

+1
Tested at: a04e599
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10042/8526/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10042/8526/summary.html

[davidlange6]

+1