Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed remnant from old functionality #10046

Merged
merged 1 commit into from Jul 9, 2015

Conversation

shchauha
Copy link

@shchauha shchauha commented Jul 6, 2015

Changed a break to continue, It was remnant from an old functionality

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2015

A new Pull Request was created by @shchauha (Shubhanshu Chauhan) for CMSSW_7_6_X.

Removed remnant from old functionality

It involves the following packages:

FastSimulation/Tracking

@cmsbuild, @ssekmen, @civanch, @mdhildreth, @lveldere can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @matt-komm this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@lveldere
Copy link
Contributor

lveldere commented Jul 6, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2015

@lveldere
Copy link
Contributor

lveldere commented Jul 9, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants