Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop egmGsfElectronIDs and egmPhotonIDs from RECO/AOD (74X) #10065

Merged
merged 1 commit into from Jul 9, 2015

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Jul 7, 2015

backport of #10063

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2015

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_4_X.

Drop egmGsfElectronIDs and egmPhotonIDs from RECO/AOD (74X)

It involves the following packages:

RecoEgamma/Configuration

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Jul 7, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2015

@slava77
Copy link
Contributor

slava77 commented Jul 8, 2015

+1

for #10065 a4cd43a

  • changes in the code are as expected
  • jenkins tests in the currently setup workflows show no differences
  • reminder: the issue fixed in this PR appears in RECO+miniAOD runs where transient products from modules belonging only to miniAOD inadvertently end up in the RECO event content due to keep *_egmGsfElectronIDs_*_* that was there before. This was replaced by a drop statement (which is probably an overkill, but OK)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants