Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix one histogram name in MultiTrackValidator #10068

Merged
merged 1 commit into from Jul 9, 2015

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Jul 7, 2015

The name of "number of pileup tracks vs dz" histogram was left "incorrect" in #9201, that resulted the "pileup rate vs. dz" plot being missing in 750pre6 RelVals. This PR renames the histogram such that postProcessorTrack picks it up to calculate the pileup rate.

Tested in CMSSW_7_5_0_pre6, expected changes are

  • num_pileup_versus_dz -> num_pileup_dz rename
  • appearance of pileuprate_dz histogram
  • knock-on effects in globalEfficiencies histograms

@rovere @VinInn

Now postProcessorTrack will calculate the pileuprate vs dz.
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2015

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_6_X.

Fix one histogram name in MultiTrackValidator

It involves the following packages:

Validation/RecoTrack

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @rovere, @VinInn, @cerati, @wmtford, @istaslis, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Jul 8, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2015

@davidlange6
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2015

@makortel makortel deleted the fixMtvPileupDz branch October 20, 2016 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants