Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

back port of pixel lumi dqm from 76X to 74X #10075

Merged
merged 3 commits into from Jul 31, 2015

Conversation

rpatkennyiii
Copy link
Contributor

this is a back port of this pull request: #10007

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2015

A new Pull Request was created by @mojoe137 (Pat Kenny) for CMSSW_7_4_X.

back port from 76X to 74X

It involves the following packages:

DQM/Integration
DQM/PixelLumi

The following packages do not have a category, yet:

DQM/PixelLumi

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
@threus, @batinkov this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Jul 8, 2015

status:
this PR is being tested on the playback and will be deployed in production soon (later today/tomorrow) given the fact that it is urgent.
however there are a couple of things to be fixed before we go with a merge:

  • please update the PixelLumiDQM to take the list of deadModules from DB (the current hardcoded list is out of date)
  • please replace the filter ZeroBiasSelector_cfi.py with an option at the source directly in the pixellumi_dqm_sourceclient-live_cfg.py config [1]

[1]
add one line like this:
process.source.SelectEvents = cms.untracked.vstring('HLT__Mu_')

if you want to be more specific, you can OR things:
process.source.SelectEvents = cms.untracked.vstring('HLT__SingleMu_', 'HLT__DoubleMu_')

@deguio
Copy link
Contributor

deguio commented Jul 8, 2015

-1
rejecting for now to make sure we don't forget

@davidlange6
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Jul 28, 2015

+1
online only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants