Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastSim: make matched hits aware of order of components (75X, BUGFIX) #10079

Merged
merged 3 commits into from Jul 9, 2015
Merged

FastSim: make matched hits aware of order of components (75X, BUGFIX) #10079

merged 3 commits into from Jul 9, 2015

Conversation

lveldere
Copy link
Contributor

@lveldere lveldere commented Jul 7, 2015

Fixes low efficiency for high purity tracks observed in validation of 750pre6, introduced in #9595

Expected changes:
FullSim: none
FastSim: increased tracking efficiency, especially for high purity

@lveldere
Copy link
Contributor Author

lveldere commented Jul 7, 2015

please test

@lveldere lveldere changed the title FastSim: make matched hits aware of order of components FastSim: make matched hits aware of order of components (75X, BUGFIX) Jul 7, 2015
@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone Jul 7, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2015

A new Pull Request was created by @lveldere for CMSSW_7_5_X.

FastSim: make matched hits aware of order of components (75X, BUGFIX)

It involves the following packages:

DataFormats/TrackerRecHit2D
FastSimulation/Tracking
FastSimulation/TrackingRecHitProducer

@civanch, @lveldere, @cvuosalo, @ssekmen, @mdhildreth, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @makortel, @VinInn, @gpetruc, @matt-komm this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Jul 9, 2015
FastSim: make matched hits aware of order of components (75X, BUGFIX)
@davidlange6 davidlange6 merged commit a9a791d into cms-sw:CMSSW_7_5_X Jul 9, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants