MINIAOD: Whitelist IVF cands in packing + BugFix on SharedTracks helpers #10088
Conversation
|
A new Pull Request was created by @arizzi for CMSSW_7_5_X. MINIAOD: Whitelist IVF cands in packing It involves the following packages: PhysicsTools/PatAlgos @cmsbuild, @cvuosalo, @vadler, @monttj, @slava77 can you please review it and eventually sign? Thanks. |
| @@ -25,7 +25,7 @@ namespace vertexTools { | |||
| iter != svTracks.end(); iter++) | |||
| { | |||
| if( std::abs((*iter)->bestTrack()->dz()-pv.z())/(*iter)->bestTrack()->dzError() < maxsigma && | |||
| std::abs((*iter)->bestTrack()->dxy(pv.position())/(*iter)->bestTrack()->dxyError() < maxsigma ) | |||
| std::abs((*iter)->bestTrack()->dxy(pv.position())/(*iter)->bestTrack()->dxyError()) < maxsigma | |||
There was a problem hiding this comment.
if this changes RECO, please submit a separate PR or at least make this bugfix evident in the PR subject.
There was a problem hiding this comment.
I cannot right now, it is one character fix...making another PR is quite an overhead
There was a problem hiding this comment.
please at least update the subject of the PR to mention this bugfix (it's going to affect the cand-based taggers, right?)
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
+1 |
MINIAOD: Whitelist IVF cands in packing + BugFix on SharedTracks helpers
With this the daughters of IVF VertexCandidates are whitelisted for track detail saving in miniaod packed candidates.
In addition a bug fix of parenthesis position has been applied in vertices SharedTracks computation
@ferencek @gpetruc @pvmulder