bsunanda:Run2-hcx20 Update the scenarios by adding relevant xml files

[bsunanda]

Split some of the ECAL xml files to enable PhaseII definition and add files relevant for new ways of defining Hcal geometry

[cmsbuild]

A new Pull Request was created by @bsunanda for CMSSW_7_6_X.

bsunanda:Run2-hcx20 Update the scenarios by adding relevant xml files

It involves the following packages:

Geometry/CMSCommonData
Geometry/EcalCommonData

@cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please review it and eventually sign? Thanks.
@ghellwig, @argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[ianna]

@bsunanda - why?

[ianna]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[ianna]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

@bsunanda - why the cms.vstring() is needed?

[bsunanda]

The list is too long

---

From: David Lange [notifications@github.com]
Sent: 09 July 2015 21:37
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Run2-hcx20 Update the scenarios by adding relevant xml files (#10100)

In Geometry/CMSCommonData/python/Phase1_R34F16_cmsSimIdealGeometryXML_cfi.pyhttps://github.com//pull/10100#discussion_r34294339:

@@ -232,7 +236,7 @@
'Geometry/ForwardCommonData/data/totemRotations.xml',
'Geometry/ForwardCommonData/data/totemt1.xml',
'Geometry/ForwardCommonData/data/totemt2.xml',

•    'Geometry/ForwardCommonData/data/ionpump.xml',
  

•    'Geometry/ForwardCommonData/data/ionpump.xml')+cms.vstring(
  

@bsunandahttps://github.com/bsunanda - why the cms.vstring() is needed?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/10100/files#r34294339.

[davidlange6]

+1