Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated code adding GEM hits in STA reconstruction #10109

Merged
merged 4 commits into from Jul 29, 2015

Conversation

archiesharma
Copy link
Contributor

Closing the old pull request #9806, and creating this new pull request in a new area with all the updates and implementing all the comments from the old pull request #9806 :

  1. Hit Pattern changes (replacing GEM rolls with GEM stations) are applied and in the very recent IB release CMSSW_7_6_X_2015-07-04-2300 so as not to conflict with the other changes made in Migrate HitPattern to use TrackerTopology #9959.
  2. Untracked parameters in MuonServiceProxy are changed to tracked.
  3. All the commented lines in the code are removed.
  4. Tests are done with runTheMatrix.py -l 11325.0 --useInput all and all of them are ok.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2015

A new Pull Request was created by @archiesharma for CMSSW_7_6_X.

Updated code adding GEM hits in STA reconstruction

It involves the following packages:

DQM/DTMonitorModule
DataFormats/TrackReco
RecoMuon/CosmicMuonProducer
RecoMuon/DetLayers
RecoMuon/GlobalTrackingTools
RecoMuon/L2MuonProducer
RecoMuon/L3MuonProducer
RecoMuon/MeasurementDet
RecoMuon/MuonSeedGenerator
RecoMuon/Navigation
RecoMuon/StandAloneMuonProducer
RecoMuon/StandAloneTrackFinder
RecoMuon/TrackingTools
RecoMuon/TransientTrackingRecHit

@cmsbuild, @cvuosalo, @danduggan, @deguio, @slava77 can you please review it and eventually sign? Thanks.
@battibass, @makortel, @abbiendi, @jhgoh, @VinInn, @bellan, @gpetruc, @trocino, @amagitte, @bachtis, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Jul 9, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2015

-1

Tested at: ca6b012
I found errors in the following unit tests:

---> test runtestTqafTopEventSelection had ERRORS
---> test runtestTqafTopHitFit had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10109/5660/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
b249178
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10109/5660/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10109/5660/git-merge-result

@slava77
Copy link
Contributor

slava77 commented Jul 28, 2015

+1

for #10109 0407562

  • the forward port is done appropriately (no interference with the current run1/run2 reco/simulation) as confirmed in jenkins test
  • jenkins tests pass and comparisons with the baseline show no differences

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants