Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unneeded boost header #10110

Merged

Conversation

Dr15Jones
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2015

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_6_X.

Removed unneeded boost header

It involves the following packages:

DataFormats/Common

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @wddgit, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor Author

please test

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Jul 9, 2015
@davidlange6 davidlange6 merged commit 3c3ca6a into cms-sw:CMSSW_7_6_X Jul 9, 2015
@cmsbuild
Copy link
Contributor

-1

Tested at: 15c390f
I found errors in the following unit tests:

---> test HcalGeometryTest had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10110/6095/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
c735bcd
a8e0765
cbab751
736e1f4
32e1b44
b249178
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10110/6095/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10110/6095/git-merge-result

@cmsbuild
Copy link
Contributor

@Dr15Jones Dr15Jones deleted the removedUnneededBoostHeaders branch August 14, 2015 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants