Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move PCA pos calc into plugins #10152

Merged
merged 1 commit into from Jul 13, 2015

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Jul 11, 2015

Avoids problem reported by Gaelle that was causing a plugin to get loaded twice.
Matrix test pass now in my local area.

@boudoul

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_6_2_X_SLHC.

Move PCA pos calc into plugins

It involves the following packages:

RecoParticleFlow/PFClusterProducer

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @bachtis this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cvuosalo
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@mark-grimes
Copy link

Tested privately along with #10156, tests 14062, 15662, 17662 and 17000 all fine (standard HGCal and a few arbitrary HGCal de-scope scenarios, only 2 events with 17000 since 140 pileup takes aaaages). Small problem with 17800 but that's (EDIT - ..not..) down to this PR (see discussion on #10156). Happy to merge but might as well wait for the automatic tests to come back, although I need to update the test numbers for those.

@mark-grimes
Copy link

merge

I'm happy from private testing (described above) that everything is okay. Need to get the release out and most of the automatic tests are for different scenarios.

cmsbuild added a commit that referenced this pull request Jul 13, 2015
@cmsbuild cmsbuild merged commit 54c18fa into cms-sw:CMSSW_6_2_X_SLHC Jul 13, 2015
@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants