New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move PCA pos calc into plugins #10152
Conversation
A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_6_2_X_SLHC. Move PCA pos calc into plugins It involves the following packages: RecoParticleFlow/PFClusterProducer @cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Tested privately along with #10156, tests 14062, 15662, 17662 and 17000 all fine (standard HGCal and a few arbitrary HGCal de-scope scenarios, only 2 events with 17000 since 140 pileup takes aaaages). Small problem with 17800 but that's (EDIT - ..not..) down to this PR (see discussion on #10156). Happy to merge but might as well wait for the automatic tests to come back, although I need to update the test numbers for those. |
merge I'm happy from private testing (described above) that everything is okay. Need to get the release out and most of the automatic tests are for different scenarios. |
Move PCA pos calc into plugins
Avoids problem reported by Gaelle that was causing a plugin to get loaded twice.
Matrix test pass now in my local area.
@boudoul