New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates the Run2 era to match recent changes in the customisations #10187
Updates the Run2 era to match recent changes in the customisations #10187
Conversation
A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_7_6_X. Era updates for FastSim It involves the following packages: FastSimulation/Configuration @cmsbuild, @ssekmen, @civanch, @mdhildreth, @lveldere can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins. |
-1 runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log 135.4 step1 runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log you can see the results of the tests here: |
Argh! It's dependant on #10171. I'll add those commits to this too and resubmit. |
@mark-grimes: we are trying to remove the L1 menu selection from configuration and instead use the versions in the GT. Will these changes conflict with those changes (See: PR #10184). (Also: thank you by the way for jumping in and helping out with this mess of L1T configs...) Can you also point me to a talk or something to help me get up to speed with the intended use of the Eras... this came up when I was mostly offline so I don't yet understand what should go in the GT versus the customizations. |
@mulhearn, yes I saw #10184 after submitting this batch of PRs. That doesn't conflict in the git sense, but it diverges the era and customisation functions. Eras are intended as a replacement for customisation functions, mainly so that changes are in the same file as the original. Hence changes are devolved to the relevant experts rather than a monolithic central area. There is a twiki page, let me know if any of it isn't clear. |
Thanks! |
About to push some changes that bring the latest updates. With this and #10172 the eras and customisation functions are in line. There is a summary of the differences (verbatim differences are expected) for CMSSW_7_6_X_2015-07-28-1100 at http://grimes.web.cern.ch/grimes/eraProcessDiffs/processDiffs-7_6_X_2015-07-28-1100-PR10172-PR10187.html. |
52f4500
to
5e6286c
Compare
Found some extra collections in the era configurations: So, there will need to be another PR to fix that. |
Actually, ignore that last comment. I was accidentally using the wrong branch, output collections are exactly the same. The report in the link above has been updated. |
Updates the Run2 era to match recent changes in the customisations
Copies the L1 trigger era updates from FullSim to FastSim. Has no effect whatsoever unless one of the Run 2 eras is active.
EDIT since opening - since the L1 FullSim changes were requires for this PR, I included them here and closed the other separate PR.