Addition of histograms for SiStrip : Cluster widths vs amplitudes

[hdelanno]

No description provided.

[cmsbuild]

A new Pull Request was created by @hdelanno (Hugo Delannoy) for CMSSW_7_6_X.

Addition of histograms for SiStrip : Cluster widths vs amplitudes

It involves the following packages:

DQM/SiStripMonitorCluster

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
@threus this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[deguio]

please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

-1
Tested at: 1611895
I found an error when building:

>> Subsystem FWCore built
Copying tmp/slc6_amd64_gcc491/src/DQMServices/Diagnostic/bin/MakeDeanHTML/MakeDeanHTML to productstore area:
/afs/cern.ch/cms/sw/ReleaseCandidates/volC/slc6_amd64_gcc491/external/gcc/4.9.1-cms/bin/../lib/gcc/x86_64-redhat-linux-gnu/4.9.1/../../../../x86_64-redhat-linux-gnu/bin/ld: cannot find -lFWCoreFramework
/afs/cern.ch/cms/sw/ReleaseCandidates/volC/slc6_amd64_gcc491/external/gcc/4.9.1-cms/bin/../lib/gcc/x86_64-redhat-linux-gnu/4.9.1/../../../../x86_64-redhat-linux-gnu/bin/ld: cannot find -lDataFormatsCommon
/afs/cern.ch/cms/sw/ReleaseCandidates/volC/slc6_amd64_gcc491/external/gcc/4.9.1-cms/bin/../lib/gcc/x86_64-redhat-linux-gnu/4.9.1/../../../../x86_64-redhat-linux-gnu/bin/ld: cannot find -lDataFormatsStdDictionaries
collect2: error: ld returned 1 exit status
gmake: **\* [tmp/slc6_amd64_gcc491/src/DQMServices/Core/src/DQMServicesCore/libDQMServicesCore.so] Error 1
Leaving library rule at DQMServices/Core
>> Building edm plugin tmp/slc6_amd64_gcc491/src/DQMOffline/Trigger/plugins/DQMOfflineTriggerPlugins/libDQMOfflineTriggerPlugins.so
>> Building edm plugin tmp/slc6_amd64_gcc491/src/DQMOffline/Trigger/src/DQMOfflineTrigger/libDQMOfflineTrigger.so
>> Building edm plugin tmp/slc6_amd64_gcc491/src/DQM/SiStripMonitorCluster/src/DQMSiStripMonitorCluster/libDQMSiStripMonitorCluster.so


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10242/6270/summary.html

[hdelanno]

Hi @deguio
As you can see in the comment of @threus we'd like to keep the number of bins as it is, but we have changed the subdet/layer switches to False in order to only have one plot displayed (and we can reprocess locally with all plots on if needed for investigating).
If it is ok for you, could you reconsider this request? Thank you very much!

[cmsbuild]

Pull request #10242 was updated. @cmsbuild, @danduggan, @deguio can you please check and sign again.

[danduggan]

please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: 19f75c5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10242/7388/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10242/7388/summary.html

[deguio]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1