Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding HLT object monitoring to HLT online DQM #10278

Merged
merged 1 commit into from Aug 2, 2015

Conversation

muell149
Copy link
Contributor

updating HLT object monitoring for cleaner booking and fixing a few histogram axis ranges.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @muell149 (Charlie Mueller) for CMSSW_7_6_X.

adding HLT object monitoring to HLT online DQM

It involves the following packages:

DQM/HLTEvF
DQM/Integration

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
@threus, @batinkov this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Jul 27, 2015

ciao @muell149
should I assume that an additional commit will come for this PR? or this is final?
let me know.
thanks,
F.

@muell149
Copy link
Contributor Author

ciao @deguio there aren't any expected additional commits coming anytime this week/next week. This is final.

cheers
charlie

@deguio
Copy link
Contributor

deguio commented Jul 27, 2015

+1
ok. the code runs at the online only and it has been tested since a while.
I thought we agreed on some optimization (loops mainly). I guess you can do that with a separate PR.

ciao and thanks,
F.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@muell149
Copy link
Contributor Author

@deguio The optimization is present in this PR. booking of hists is automated with loops and the number of data structure overall is reduced. There is also more parameters specified now in the python cfg. This shortened things by ~250 lines of code and the running time is roughly identical to before.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants