Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bsunanda:Run2-gem08 Add the GE21 geometry with pointing strips #10281

Merged
merged 1 commit into from Jul 21, 2015

Conversation

bsunanda
Copy link
Contributor

The GE21 geometry in v6 is corrected and the one in v7 is with radial strips pointing to the beam axis

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for CMSSW_7_6_X.

bsunanda:Run2-gem08 Add the GE21 geometry with pointing strips

It involves the following packages:

Geometry/MuonCommonData

@cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ianna
Copy link
Contributor

ianna commented Jul 20, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-1
Tested at: e19d9cd
you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10281/6370/summary.html

@bsunanda
Copy link
Contributor Author

Can you start the test after correcting the IB? This is not a fault of the PR but of the IB.


From: cmsbuild [notifications@github.com]
Sent: 20 July 2015 19:07
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Run2-gem08 Add the GE21 geometry with pointing strips (#10281)

-1
Tested at: e19d9cdhttps://github.com/cms-sw/cmssw/commit/e19d9cd534c016fa3e3552474d42e261372694df
you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10281/6370/summary.html


Reply to this email directly or view it on GitHubhttps://github.com//pull/10281#issuecomment-122954042.

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@ianna
Copy link
Contributor

ianna commented Jul 21, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants