Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HF MC changes "a la" data: ZS removed from config and Digi size set to 4 #10314

Merged
merged 1 commit into from Jul 27, 2015

Conversation

abdoulline
Copy link

ZS to be updated also in 75X and 76X MC conditions.

runTheMatrix.py -s --useInput all is OK

@abdoulline abdoulline changed the title HF MC changes "a la" data: ZS removed in config and Digi size set to 4 HF MC changes "a la" data: ZS removed from config and Digi size set to 4 Jul 23, 2015
@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Jul 23, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @abdoulline for CMSSW_7_6_X.

HF MC changes "a la" data: ZS removed from config and Digi size set to 4

It involves the following packages:

SimCalorimetry/HcalSimProducers
SimCalorimetry/HcalZeroSuppressionProducers

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@civanch
Copy link
Contributor

civanch commented Jul 23, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@civanch
Copy link
Contributor

civanch commented Jul 23, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

@abdoulline - could we summarize this briefly in the sim meeting today?

@abdoulline
Copy link
Author

I hope HCAL DPG today will finish more or less in time, then I'll pass by.

Briefly speaking (just in case...) this is a minor change in HF digi size
(to finally bring it to the data one, removing long-lasting
discrepancy...).
Another change - removal of HF ZS in config (to formally correspond to
the absence of HF ZS in the current data). This has no effect on
standard streams, as by default ZS level comes from Offline DB.

NB: we're going to remove HF ZS via (MC) conditions both in 750 (well, I
know this is arguable...) and 76X.

On Fri, 24 Jul 2015, David Lange wrote:

@abdoulline - could we summarize this briefly in the sim meeting today?


Reply to this email directly or view it on GitHub.[AEx02o-l_iWA_Eexf32pzydxDWRC7oVHks5ogdqVgaJpZM4FeUKL.gif]

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jul 27, 2015
HF MC changes "a la" data:  ZS removed from config  and Digi size set to 4
@cmsbuild cmsbuild merged commit 06d37c1 into cms-sw:CMSSW_7_6_X Jul 27, 2015
@abdoulline abdoulline deleted the HF_update_ZS_and_TSsize branch April 13, 2017 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants