Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rivet consumes migration backport to 75X #10323

Closed
wants to merge 4 commits into from

Conversation

jhgoh
Copy link
Contributor

@jhgoh jhgoh commented Jul 23, 2015

This is backport of #10320 and #10311
RivetAnalyzer and GenParticles2HepMCConverter modules were not migrated to the consumes() getByToken.

These are technical changes. No change in physics.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jhgoh (Junghwan John Goh) for CMSSW_7_5_X.

Rivet consumes migration backport to 75X

It involves the following packages:

GeneratorInterface/RivetInterface

@vciulli, @cmsbuild, @covarell, @bendavid, @thuer can you please review it and eventually sign? Thanks.
@mkirsano this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@davidlange6
Copy link
Contributor

Closing - not needed for HeavyIons (only planned 75x usage)

@jhgoh jhgoh deleted the RivetConsumesMigration75 branch January 30, 2016 13:42
@jhgoh jhgoh restored the RivetConsumesMigration75 branch January 30, 2016 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants