Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved performance of c-hadron origin identification (7_6_X) #10348

Merged
merged 3 commits into from Aug 9, 2015
Merged

Improved performance of c-hadron origin identification (7_6_X) #10348

merged 3 commits into from Aug 9, 2015

Conversation

bartosik-hep
Copy link
Contributor

C-hadrons performance as for b hadrons.
Example configuration extended by test of c harons.
Simpler configuration of the JetFlavour tool.

@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Jul 24, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bartosik-desy (Nazar Bartosik) for CMSSW_7_6_X.

Improved performance of c-hadron origin identification (7_6_X)

It involves the following packages:

PhysicsTools/JetMCAlgos

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
@ferencek, @acaudron, @pvmulder, @imarches this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@monttj
Copy link
Contributor

monttj commented Aug 3, 2015

please test

@monttj
Copy link
Contributor

monttj commented Aug 3, 2015

@bartosik-desy
Do we have this PR for 74X and 75X?

@bartosik-hep
Copy link
Contributor Author

@monttj Yes for 74X, but not for 75X. I can make a pull request for 75X if needed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2015

The tests are being triggered in jenkins.

@monttj
Copy link
Contributor

monttj commented Aug 3, 2015

@bartosik-desy
I guess we would like to have this feature in 75X as well?
By the way, I was not able find the same PR for 74X.

@bartosik-hep
Copy link
Contributor Author

@monttj OK, I will do so. The one for 74X is here: #10313

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2015

+1
Tested at: c2981ce
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10348/6918/summary.html

@monttj
Copy link
Contributor

monttj commented Aug 3, 2015

@bartosik-desy thank you!

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2015

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10348/6918/summary.html

@monttj
Copy link
Contributor

monttj commented Aug 5, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

davidlange6 added a commit that referenced this pull request Aug 9, 2015
@davidlange6
Merge pull request #10348 from cms-analysis-tools/CMSSW_7_6_X_genHFHa…
77953df 
…dronMatcher

Improved performance of c-hadron origin identification (7_6_X)
@davidlange6 davidlange6 merged commit 77953df into cms-sw:CMSSW_7_6_X Aug 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-approved comparison-available fully-signed orp-pending tests-approved
Projects
None yet
Milestone
CMSSW_7_6_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bartosik-hep @cmsbuild @monttj @davidlange6